Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Busy state of frame committed to history #1337

Open
aleho opened this issue Nov 12, 2024 · 1 comment
Open

Busy state of frame committed to history #1337

aleho opened this issue Nov 12, 2024 · 1 comment

Comments

@aleho
Copy link

aleho commented Nov 12, 2024

When submitting a form to a frame with advance action the frame's busy state is not cleared and committed to history. Navigating back the frame will then appear busy.

Is this the intended behavior?

A small reproducer:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no" />
    <meta name="turbo-refresh-method" content="morph">
    <title>Turbo reproducer</title>
    <script src="https://cdn.jsdelivr.net/npm/@hotwired/[email protected]/dist/turbo.es2017-umd.min.js"></script>
    <style>
        html { font-family: sans-serif; }
        turbo-frame { display: block; margin-top: 2em; padding: 1em; }
        turbo-frame[aria-busy="true"] { background-color: lightblue; }
    </style>
</head>
<body>

<turbo-frame id="top-frame" data-turbo-action="advance">
    <p>This frame is fine.</p>

    <form method="get" data-turbo-frame="_top">
        <input type="hidden" value="submitted" name="top-frame" />
        <button type="submit">Submit [target=_top]</button>
    </form>
</turbo-frame>

<turbo-frame id="busy-frame" data-turbo-action="advance">
    <p>This frame will be busy on history back navigation.</p>

    <form method="get" data-turbo-frame="busy-frame">
        <input type="hidden" value="submitted" name="busy-frame" />
        <button type="submit">Submit [target=busy-frame]</button>
    </form>
</turbo-frame>

</body>
</html>
@aleho
Copy link
Author

aleho commented Nov 25, 2024

It's not only the busy state, by the way. Form submit elements stay disabled. This gets complicated pretty quickly when submitting forms with action="get" and history navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aleho