Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK attempting to call localStorage.get() when unavailable #23

Open
mogelbrod opened this issue Aug 7, 2023 · 0 comments
Open

SDK attempting to call localStorage.get() when unavailable #23

mogelbrod opened this issue Aug 7, 2023 · 0 comments

Comments

@mogelbrod
Copy link

mogelbrod commented Aug 7, 2023

We've gotten a significant number of automated error reports from the HJ script loaded through https://static.hotjar.com/c/hotjar-${hotjarId}.js?sv=${window._hjSettings.hjsv}:

Screenshot 2023-08-07 at 13 34 26 (screenshot from Sentry)

This appears to be caused by the SDK attempting to access localStorage when unavailable, such as when in a private/incognito session. The stack trace shows that there is a canUseLocalStorage() check nearby, but it either isn't being called correctly or doesn't handle this edge case.

I couldn't find good place to report this issue to a HJ developer - feel free to point me in the right direction if this is not the place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants
@mogelbrod and others