Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/organize-texts-in-one-file #30

Open
imranariffin opened this issue Feb 10, 2019 · 2 comments
Open

refactor/organize-texts-in-one-file #30

imranariffin opened this issue Feb 10, 2019 · 2 comments
Labels

Comments

@imranariffin
Copy link
Member

Currently all text files are defined within components. I don't think this is proper practice for localization. What do you think? @cglotr

@cglotr
Copy link
Member

cglotr commented Feb 10, 2019

@imranariffin yeah, let's do localization since now the app is pretty small so it shouldn't impact the timeline too much. I don't have a lot of experience doing it tho. But, it should just be a key value mapping right?

@imranariffin
Copy link
Member Author

imranariffin commented Feb 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants