Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED flags are deprecated in PHP 7.3 #32

Open
graste opened this issue Jul 25, 2018 · 3 comments

Comments

@graste
Copy link
Member

graste commented Jul 25, 2018

FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED flags are deprecated in PHP 7.3. See https://wiki.php.net/rfc/deprecations_php_7_3

@MrHash
Copy link
Contributor

MrHash commented Jul 25, 2018

Did a quick search but didn't find usages. Is this deprecation relevant to this lib?

@Pictor13
Copy link
Member

The flags are implicitly used in filter_var(), when specifying FILTER_VALIDATE_URL.
The explicit use of the flags is deprecated (since, as I understood from this SO, makes no difference; they'll be used anyway).

So dunno if there is actual code to fix (in the code we never specify those flags explicitly).

Additionally, there is a bug report related to that, but is still open so the deprecation is not because of this one being fixed.

@graste
Copy link
Member Author

graste commented Aug 5, 2018

So you both probably did the work I intended for this ticket. 👍 I created the ticket as I saw the changelog and wanted to check whether there are side effects with the filter_var stuff we use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants