Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong encoding when adding markup calling the Embed action #36

Open
graste opened this issue Dec 7, 2016 · 1 comment
Open

Wrong encoding when adding markup calling the Embed action #36

graste opened this issue Dec 7, 2016 · 1 comment
Labels
bug

Comments

@graste
Copy link
Member

graste commented Dec 7, 2016

As shown in the screenshot, there are encoding problems when appending markup returned from the AJAX call to the Embed action.
encodingissue
@graste graste added the bug label Dec 7, 2016
graste added a commit that referenced this issue Jan 16, 2017
@graste
change escaping strategy on input type hidden/text
8c4e6fa 
to mitigate problems with double escaping them or
escaping more than necessary via twig. Probably refs #36 as well.
@Pictor13
Copy link
Member

Encoding is correct until the generation of rendered_embed, here:
https://github.com/honeybee/honeybee-agavi-cmf-vendor/blob/master/app/lib/App/ActionPack/Resource/Embed/EmbedSuccessView.php#L66

When used in the template (twig or haml), rendered_embed encoding is somehow messed up ("Löschen" -> "Löschen").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graste @Pictor13