feat: Hackday: make beam modals draggable #951
Conversation
bsholmes
requested review from
stephenh,
bdow,
ksk5280 and
chr1sjf0x
as code owners
bsholmes
force-pushed
the
hackday-misc
branch
from
d95b895 to
a9d2793
Compare
There was a problem hiding this comment.
Seems good to me! @bdow any concerns about pulling in react-draggable?
(Not saying we should re-implement the dragging natively, for sure we should use a package, but also just balancing "is dragging must have ask from UX atm?" vs. "yet another dependency in package.json".)
I don't really have any concerns about |
There was a problem hiding this comment.
@bsholmes - did you get sign off from the Design team about this? I would like to get their feedback around the UX of this. Right now, there is no indication that this can be dragged, whether that is by having an explicit "drag handle", or changing the cursor to look like it can grab and is grabbing while dragging. Could be worth providing some user feedback.
I did not, I'm not sure this is functionality we should even have but I thought creating a PR would at least get some discussion going. I did try a drag handle design and decided against it since it was a design change and I wasn't sure about it. I like the cursor change idea. Will get some design feedback before proceeding. |
using a custom selector using ids so that only the header is draggable which prevents issues when using input elements in the modal.
Lots of extraneous changes from linting