From 946a32bf41133a4ba8b8964f9cc419a0fc92e72d Mon Sep 17 00:00:00 2001
From: Stephen Haberman <shaberman@homebound.com>
Date: Fri, 18 Oct 2024 12:56:23 -0500
Subject: [PATCH] fix: Give select a more useful error message.

When the SelectField is read only.
---
 src/utils/rtl.tsx | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/utils/rtl.tsx b/src/utils/rtl.tsx
index 0a0256cd8..81902c9a4 100644
--- a/src/utils/rtl.tsx
+++ b/src/utils/rtl.tsx
@@ -1,13 +1,11 @@
-import { newLocation as _newLocation, withRouter as _withRouter } from "@homebound/rtl-react-router-utils";
+import { withRouter as _withRouter } from "@homebound/rtl-react-router-utils";
 import {
   blur as _blur,
   change as _change,
   click as _click,
   clickAndWait as _clickAndWait,
   focus as _focus,
-  getOptions as _getOptions,
   input as _input,
-  select as _select,
   type as _type,
   typeAndWait as _typeAndWait,
   wait as _wait,
@@ -17,9 +15,9 @@ import {
   Wrapper,
 } from "@homebound/rtl-utils";
 import { prettyDOM } from "@testing-library/react";
-import { fail } from "mobx-utils";
 import { ReactElement } from "react";
 import { BeamProvider } from "src/components";
+import { fail } from "src/utils/index";
 export {
   _blur as blur,
   _change as change,
@@ -27,9 +25,6 @@ export {
   _clickAndWait as clickAndWait,
   _focus as focus,
   _input as input,
-  _newLocation as newLocation,
-  _getOptions as rtlUtilGetOptions,
-  _select as rtlUtilSelect,
   _type as type,
   _typeAndWait as typeAndWait,
   _wait as wait,
@@ -277,7 +272,10 @@ export function getOptions(select: HTMLElement): string[] {
 }
 
 function findListBox(select: HTMLElement): HTMLElement {
-  const listboxId = select.getAttribute("aria-controls") || fail("aria-controls attribute not found");
+  if (select.tagName === "DIV") fail("SelectField is readOnly");
+  const listboxId =
+    select.getAttribute("aria-controls") ||
+    fail("aria-controls attribute not found, the SelectField is probably readOnly");
   return document.getElementById(listboxId) || fail("listbox not found");
 }