Add select entity to Home Connect #35398
Conversation
home-assistant
bot
added
Hacktoberfest
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 Walkthrough📝 WalkthroughWalkthroughThe changes involve updates to the Home Connect integration documentation, specifically enhancing the description of its capabilities. A new category, "Select," has been added to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeConnectIntegration
participant Device
User->>HomeConnectIntegration: Request available programs
HomeConnectIntegration->>Device: Fetch available programs
Device-->>HomeConnectIntegration: Return available programs
HomeConnectIntegration-->>User: Display available programs for selection
User->>HomeConnectIntegration: Select a program
HomeConnectIntegration->>Device: Execute selected program
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
source/_integrations/home_connect.markdown (1)
37-37: Consider adding usage examples.To enhance user understanding, consider adding:
- A simple example showing how to use the select entity in automations
- A code snippet demonstrating the YAML configuration (if applicable)
Would you like me to help draft example snippets for the documentation?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- source/_integrations/home_connect.markdown (3 hunks)
🔇 Additional comments (2)
source/_integrations/home_connect.markdown (2)
9-9: LGTM: Front matter changes are correct and well-structured.The additions of "Select" to
ha_categoryand "select" toha_platformsfollow Home Assistant's documentation standards and maintain proper alphabetical ordering.Also applies to: 24-24
37-37: Consider clarifying the relationship between program controls.While the addition clearly describes the select entity functionality, it might be helpful to clarify:
- The relationship between program switches and the select entity
- Whether users should prefer one method over the other
- If both controls can be used interchangeably
Let me check if there are any related discussions or documentation:
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Also improve a bit the program entities
| - If the device has programs, switches for each of the individual programs will be added. Note that program options cannot be configured currently. | ||
| - If the device has programs, a timestamp sensor for remaining time and a numeric sensor for the progress percentage. | ||
| - If the device has programs: | ||
| - Switches for each of the individual programs will be added. Note that program options cannot be configured currently. |
There was a problem hiding this comment.
Should I mark the switches as deprecated once home-assistant/core#131641 gets merged?
There was a problem hiding this comment.
Deprecation are generally just removed from the documentation.
home-assistant
bot
removed
the
parent-merged
frenck
added
the
cherry-picked
Proposed change
Add select entity information to Home Connect integration documentation
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit
New Features
Documentation