diff --git a/.github/workflows/default.yml b/.github/workflows/default.yml index 8ab6d85..c4ef2a8 100644 --- a/.github/workflows/default.yml +++ b/.github/workflows/default.yml @@ -1,4 +1,4 @@ -name: Development braches +name: Development branches on: push: @@ -10,10 +10,6 @@ on: jobs: build: runs-on: ubuntu-latest - strategy: - fail-fast: false - matrix: - jdk: ['11.0.5'] steps: - name: Checkout code @@ -22,7 +18,7 @@ jobs: - name: Set up JDK uses: actions/setup-java@v3 with: - java-version: ${{ matrix.jdk }} + java-version: 17 distribution: zulu cache: maven diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index a355ad1..d536eab 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -20,10 +20,10 @@ jobs: run: echo ${{ secrets.GPG_SECRET_KEYS }} | base64 --decode | gpg --import --no-tty --batch --yes # Setup JDK and Maven - - name: Set up JDK 11 + - name: Set up JDK 17 uses: actions/setup-java@v3 with: - java-version: 11.0.5 + java-version: 17 distribution: zulu cache: maven server-id: ossrh diff --git a/.java-version b/.java-version index b4de394..98d9bcb 100644 --- a/.java-version +++ b/.java-version @@ -1 +1 @@ -11 +17 diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties index 7d02699..eacdc9e 100755 --- a/.mvn/wrapper/maven-wrapper.properties +++ b/.mvn/wrapper/maven-wrapper.properties @@ -14,5 +14,5 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.5/apache-maven-3.9.5-bin.zip wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar diff --git a/examples/basic/pom.xml b/examples/basic-junit4/pom.xml similarity index 95% rename from examples/basic/pom.xml rename to examples/basic-junit4/pom.xml index ead58fe..f0f868b 100644 --- a/examples/basic/pom.xml +++ b/examples/basic-junit4/pom.xml @@ -6,10 +6,10 @@ io.holunda.testing camunda-bpm-jgiven-examples - 0.4.1 + 1.19.0 - camunda-bpm-jgiven-examples-basic + camunda-bpm-jgiven-examples-basic-junit4 jar diff --git a/examples/basic/src/main/kotlin/io/holunda/testing/examples/basic/ApprovalProcessBean.kt b/examples/basic-junit4/src/main/kotlin/io/holunda/testing/examples/basic/ApprovalProcessBean.kt similarity index 100% rename from examples/basic/src/main/kotlin/io/holunda/testing/examples/basic/ApprovalProcessBean.kt rename to examples/basic-junit4/src/main/kotlin/io/holunda/testing/examples/basic/ApprovalProcessBean.kt diff --git a/examples/basic/src/main/kotlin/io/holunda/testing/examples/basic/BasicProcessApplication.kt b/examples/basic-junit4/src/main/kotlin/io/holunda/testing/examples/basic/BasicProcessApplication.kt similarity index 100% rename from examples/basic/src/main/kotlin/io/holunda/testing/examples/basic/BasicProcessApplication.kt rename to examples/basic-junit4/src/main/kotlin/io/holunda/testing/examples/basic/BasicProcessApplication.kt diff --git a/examples/basic/src/main/resources/META-INF/processes.xml b/examples/basic-junit4/src/main/resources/META-INF/processes.xml similarity index 100% rename from examples/basic/src/main/resources/META-INF/processes.xml rename to examples/basic-junit4/src/main/resources/META-INF/processes.xml diff --git a/examples/basic/src/main/resources/approval.bpmn b/examples/basic-junit4/src/main/resources/approval.bpmn similarity index 100% rename from examples/basic/src/main/resources/approval.bpmn rename to examples/basic-junit4/src/main/resources/approval.bpmn diff --git a/examples/basic/src/test/kotlin/io/holunda/testing/examples/basic/ApprovalProcessStages.kt b/examples/basic-junit4/src/test/kotlin/io/holunda/testing/examples/basic/ApprovalProcessStages.kt similarity index 100% rename from examples/basic/src/test/kotlin/io/holunda/testing/examples/basic/ApprovalProcessStages.kt rename to examples/basic-junit4/src/test/kotlin/io/holunda/testing/examples/basic/ApprovalProcessStages.kt diff --git a/examples/basic/src/test/kotlin/io/holunda/testing/examples/basic/ApprovalProcessTest.kt b/examples/basic-junit4/src/test/kotlin/io/holunda/testing/examples/basic/ApprovalProcessTest.kt similarity index 100% rename from examples/basic/src/test/kotlin/io/holunda/testing/examples/basic/ApprovalProcessTest.kt rename to examples/basic-junit4/src/test/kotlin/io/holunda/testing/examples/basic/ApprovalProcessTest.kt diff --git a/examples/basic/src/test/resources/camunda.cfg.xml b/examples/basic-junit4/src/test/resources/camunda.cfg.xml similarity index 100% rename from examples/basic/src/test/resources/camunda.cfg.xml rename to examples/basic-junit4/src/test/resources/camunda.cfg.xml diff --git a/examples/basic/src/test/resources/logback.xml b/examples/basic-junit4/src/test/resources/logback.xml similarity index 100% rename from examples/basic/src/test/resources/logback.xml rename to examples/basic-junit4/src/test/resources/logback.xml diff --git a/examples/basic-junit5/pom.xml b/examples/basic-junit5/pom.xml index 50726c4..fa45253 100644 --- a/examples/basic-junit5/pom.xml +++ b/examples/basic-junit5/pom.xml @@ -6,7 +6,7 @@ io.holunda.testing camunda-bpm-jgiven-examples - 0.4.1 + 1.19.0 camunda-bpm-jgiven-examples-basic-junit5 diff --git a/examples/pom.xml b/examples/pom.xml index d9a0009..63679ac 100644 --- a/examples/pom.xml +++ b/examples/pom.xml @@ -6,20 +6,21 @@ io.holunda.testing camunda-bpm-jgiven-parent - 0.4.1 + 1.19.0 camunda-bpm-jgiven-examples pom - 2.7.5 - 2.0.0 - 6.18.0 + 2.7.6 + 2.2.0 + 6.19.1 + 4.13.2 - basic + basic-junit4 basic-junit5 @@ -68,8 +69,12 @@ jgiven-junit5 ${jgiven.version} - - + + + junit + junit + ${junit.version} + diff --git a/extension/pom.xml b/extension/pom.xml index 99c0ca2..ecefb0c 100644 --- a/extension/pom.xml +++ b/extension/pom.xml @@ -6,7 +6,7 @@ io.holunda.testing camunda-bpm-jgiven-parent - 0.4.1 + 1.19.0 camunda-bpm-jgiven @@ -30,11 +30,6 @@ camunda-engine provided - - junit - junit - provided - org.assertj assertj-core diff --git a/extension/src/main/kotlin/io/holunda/camunda/bpm/extension/jgiven/ProcessStage.kt b/extension/src/main/kotlin/io/holunda/camunda/bpm/extension/jgiven/ProcessStage.kt index 5b6fe7d..b48c457 100644 --- a/extension/src/main/kotlin/io/holunda/camunda/bpm/extension/jgiven/ProcessStage.kt +++ b/extension/src/main/kotlin/io/holunda/camunda/bpm/extension/jgiven/ProcessStage.kt @@ -98,9 +98,10 @@ class ProcessStage, PROCESS_BEAN : Suppl @As("process waits in activities $") fun process_waits_in(@QuotedVarargs vararg activityId: String) = step { require(activityId.isNotEmpty()) { "At least one activity id must be provided" } - activityId.map { - val job = job(it) - assertThat(job).`as`("Expecting the process to be waiting in activity '$it', but it was not.").isNotNull + + val processInstance = processInstanceSupplier.get() + activityId.forEach { + assertThat(processInstance).isWaitingAt(it) } } @@ -200,7 +201,7 @@ class ProcessStage, PROCESS_BEAN : Suppl * @param users list of candidate users that must be candidate. * @return fluent stage. */ - fun task_is_visible_to_users(@QuotedVarargs users: Array): SELF = step { + fun task_is_visible_to_users(@QuotedVarargs vararg users: String): SELF = step { val task = task() users.forEach { user -> assertThat(task).hasCandidateUser(user) } } @@ -210,7 +211,7 @@ class ProcessStage, PROCESS_BEAN : Suppl * @param groups list of candidate groups that must be candidate. * @return fluent stage. */ - fun task_is_visible_to_groups(@QuotedVarargs groups: Array): SELF = step { + fun task_is_visible_to_groups(@QuotedVarargs vararg groups: String): SELF = step { val task = task() groups.forEach { group -> assertThat(task).hasCandidateGroup(group) } } @@ -320,7 +321,7 @@ class ProcessStage, PROCESS_BEAN : Suppl * @return fluent stage. */ @As("variables $ are not present") - fun variables_are_not_present(@QuotedVarargs variableNames: Array): SELF = step { + fun variables_are_not_present(@QuotedVarargs vararg variableNames: String): SELF = step { assertThat(processInstanceSupplier.get()) .`as`("variables ${variableNames.joinToString(", ")} should not be present") .variables().doesNotContainKeys(*variableNames) diff --git a/pom.xml b/pom.xml index cb097b9..0f1de98 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ io.holunda.testing camunda-bpm-jgiven-parent - 0.4.1 + 1.19.0 pom @@ -15,14 +15,13 @@ - 7.18.0 - 1.2.5 - 4.13.2 + 7.19.0 + 1.3.0 3.24.2 - 1.2.5.0 + 1.3.0.0 - 11 - 1.8.10 + 17 + 1.9.10 true ${java.version} ${java.version} @@ -56,11 +55,6 @@ jgiven-junit5 ${jgiven.version} - - junit - junit - ${junit.version} - org.assertj assertj-core @@ -107,13 +101,16 @@ clean package + src/main/kotlin + src/test/kotlin + org.apache.maven.plugins maven-enforcer-plugin - 3.2.1 + 3.4.1 enforce-maven @@ -123,7 +120,7 @@ - 3.6.0 + 3.9.0 ${java.version} @@ -138,7 +135,7 @@ org.apache.maven.plugins maven-clean-plugin - 3.2.0 + 3.3.1 @@ -152,12 +149,10 @@ ${java.version} - default-compile none - default-testCompile none @@ -182,20 +177,20 @@ org.apache.maven.plugins maven-surefire-plugin - 3.0.0 + 3.1.2 org.apache.maven.plugins maven-failsafe-plugin - 3.0.0 + 3.1.2 org.apache.maven.plugins maven-resources-plugin - 3.3.0 + 3.3.1 UTF-8 @@ -205,7 +200,7 @@ com.amashchenko.maven.plugin gitflow-maven-plugin - 1.19.0 + 1.20.0 master @@ -229,8 +224,8 @@ ${kotlin.version} ${java.version} - 1.5 - 1.5 + 1.9 + 1.9 spring jpa @@ -301,7 +296,7 @@ org.jetbrains.dokka dokka-maven-plugin - 1.8.10 + 1.9.0 test @@ -317,7 +312,7 @@ org.codehaus.mojo build-helper-maven-plugin - 3.3.0 + 3.4.0 generate-sources @@ -337,7 +332,7 @@ org.apache.maven.plugins maven-source-plugin - 3.2.1 + 3.3.0 attach-sources @@ -357,7 +352,7 @@ org.apache.maven.plugins maven-gpg-plugin - 3.0.1 + 3.1.0 --batch @@ -380,7 +375,7 @@ maven-deploy-plugin - 3.1.0 + 3.1.1 true @@ -408,7 +403,7 @@ maven-install-plugin - 3.1.0 + 3.1.1 @@ -521,6 +516,13 @@ Holisticon AG https://www.holisticon.de + + jangalinski + Jan Galinski + jan.galinski@holisticon.de + Holisticon AG + https://www.holisticon.de +