Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test assertions in org.apache.helix.rest.metadatastore.TestZkMetadataStoreDirectory #2645

Closed
hofi1 opened this issue Oct 5, 2023 · 0 comments · Fixed by #2666 · May be fixed by hofi1/helix#1
Closed

flaky test assertions in org.apache.helix.rest.metadatastore.TestZkMetadataStoreDirectory #2645

hofi1 opened this issue Oct 5, 2023 · 0 comments · Fixed by #2666 · May be fixed by hofi1/helix#1
Labels
bug Something isn't working

Comments

@hofi1
Copy link
Contributor

hofi1 commented Oct 5, 2023 •
edited
Loading

Describe the bug

The test assertions in org.apache.helix.rest.metadatastore.TestZkMetadataStoreDirectory#testGetAllMetadataStoreRealms and org.apache.helix.rest.metadatastore.TestZkMetadataStoreDirectory#testGetAllShardingKeys are flaky.
These tests compare two sets for containing the same elements in the same order – but it is not deterministic in which order the elements are returned from a set – resulting in a flaky test.

To Reproduce

run:

mvn -pl helix-rest edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.helix.rest.metadatastore.TestZkMetadataStoreDirectory

Expected behavior

Test should not be flaky – it should pass or fail (in the current case it should pass)

Additional context

non
@hofi1 hofi1 added the bug Something isn't working label Oct 5, 2023
@hofi1 hofi1 changed the title flaky test assertion in org.apache.helix.rest.metadatastore.TestZkMetadataStoreDirectory#testComputePartitionAssignment flaky test assertions in org.apache.helix.rest.metadatastore.TestZkMetadataStoreDirectory#testComputePartitionAssignment Oct 5, 2023
@hofi1 hofi1 mentioned this issue Oct 5, 2023
Open
1 task
@hofi1 hofi1 changed the title flaky test assertions in org.apache.helix.rest.metadatastore.TestZkMetadataStoreDirectory#testComputePartitionAssignment flaky test assertions in org.apache.helix.rest.metadatastore.TestZkMetadataStoreDirectory Oct 5, 2023
hofi1 pushed a commit to hofi1/helix that referenced this issue Oct 5, 2023
Fix flaky tests (apache#2645)
9cd4181 
in org.apache.helix.rest.metadatastore.
TestZkMetadataStoreDirectory
@hofi1 hofi1 mentioned this issue Oct 17, 2023
Merged
1 task
junkaixue pushed a commit that referenced this issue Feb 27, 2024
@hofi1
Fix flaky tests (#2645) (#2666)
7ba774f 
in org.apache.helix.rest.metadatastore.
TestZkMetadataStoreDirectory

Co-authored-by: simonh5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@hofi1