Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order build process for onbuild, aptfile #7

Open
doprdele opened this issue Nov 15, 2019 · 2 comments
Open

Re-order build process for onbuild, aptfile #7

doprdele opened this issue Nov 15, 2019 · 2 comments
Assignees
Labels
bug Something isn't working C.Undefined The component(s) labels that this belongs to not yet assigned Epic.Undefined This story does not belong to an epic

Comments

@doprdele
Copy link

Describe the bug

Packrat libraries are installed first, rather than after onbuild and aptfile. This makes installing rJava impossible.

To Reproduce

Add an onbuild with

#!/bin/bash
# install java jdk
apt-get update -q
apt-get install -qy --no-install-recommends openjdk-8-jdk openjdk-8-jre
rm -rf /var/lib/apt/lists/*

# configure R for Java
R CMD javareconf &> /dev/null

to the example and try to build it.

Expected behavior

Docker container builds and rJava is installed.

@doprdele doprdele added bug Something isn't working Epic.Undefined This story does not belong to an epic C.Undefined The component(s) labels that this belongs to not yet assigned labels Nov 15, 2019
@doprdele doprdele self-assigned this Nov 15, 2019
@doprdele
Copy link
Author

doprdele commented Nov 15, 2019

This is ready for QA. If you follow the example in the documentation for rJava here https://hmdc.gitbook.io/r/config/addsystempackages, the sample heroku docker app should work.

Steps to QA:

If testing locally, you will need to
docker pull hmdc/heroku-docker-r:3.6.1-shiny
to get the latest container image.

@mreekie
Copy link

mreekie commented Nov 15, 2019

The docker container for R allows ou to run custom code at the beginnning.
Figures people will be installing Java at this point. This is a system package.
The issue is that any system packages like java need to be installed prior to installing any R library packages. This was not happening. This issue addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C.Undefined The component(s) labels that this belongs to not yet assigned Epic.Undefined This story does not belong to an epic
Projects
None yet
Development

No branches or pull requests

2 participants