Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Witness contract random weighting buggy if num backup > 1 #43

Open
eonwarped opened this issue Jan 29, 2021 · 0 comments
Open

Witness contract random weighting buggy if num backup > 1 #43

eonwarped opened this issue Jan 29, 2021 · 0 comments

Comments

@eonwarped
Copy link
Contributor

This is a placeholder tracking item in the event that we decide to increase the number of backup witnesses for P2P.

Right now, the selection for witnesses does a single loop down the rest of the witnesses after the top after choosing one random weight. The problem with this is that if the weight selected is near the end of the list, it will not choose enough witnesses to fill the schedule. The probability of being selected for a particular backup witness slot is also no longer directly proportional to approval weight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant