Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create content for repository data-bag #29

Open
sbocconi opened this issue Jan 7, 2016 · 9 comments
Open

Create content for repository data-bag #29

sbocconi opened this issue Jan 7, 2016 · 9 comments

Comments

@sbocconi
Copy link

sbocconi commented Jan 7, 2016

With npm -v 3.3.12 and node -v 5.3.0 npm install fails with

npm ERR! Darwin 15.2.0
npm ERR! argv "/usr/local/Cellar/node/5.3.0/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v5.3.0
npm ERR! npm  v3.3.12
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: `node-gyp rebuild`
npm ERR! Exit status 1

Upgrading to the latest release fixes the problem for me, but might break with other versions of node/npm?

Stefanos-MacBook-Pro:data SB$ git diff
diff --git a/package.json b/package.json
index afb2766..62b1d46 100644
--- a/package.json
+++ b/package.json
@@ -21,7 +21,7 @@
     "geojsonhint": "^1.0.0",
     "highland": "^2.5.1",
     "is-my-json-valid": "^2.10.1",
-    "level": "^0.19.1",
+    "level": "^1.4.0",
     "minimist": "^1.1.1",
     "ndjson": "^1.3.0",
     "pg": "^4.3.0",
@bertspaan
Copy link
Member

I've been working on a new version of the data package: https://github.com/histograph/data/tree/data-modules

I've moved all dataset-specific logic out of data module, and into separate modules:

I'm using this version here in NYC, with newest Node + NPM. However, I've not changed NWB + BAG data modules. I can explain how to make one! It's easy!
And then I can merge data-modules branch of this repo into master.

@bertspaan
Copy link
Member

By the way: hello @sbocconi!

@sbocconi
Copy link
Author

sbocconi commented Jan 7, 2016

hello @bertspaan!!

@bertspaan
Copy link
Member

This is how data module works in new data-modules branch:

  • It looks for subdirectories named data-xxx in a specified directory (i.e. data-tgn)
  • From such a directory, it loads xxx.js (i.e. require('data-tgn/tgn.js'))
  • (You have to make sure that you've ran npm install for each data module)

Each data module should have the following API:

module.exports.steps = [
  step1, // step1 and step2 are functions inside the data module
  step2
];

@sbocconi sbocconi self-assigned this Jan 19, 2016
@sbocconi sbocconi added the ready label Jan 19, 2016
@sbocconi sbocconi changed the title Level version in package.json does not work with recent node and npm versions Create content for repositories data-nwb and data-bag Jan 20, 2016
@sbocconi
Copy link
Author

I changed the title of this issue since the original one is fixed but the discussion here is useful to solve the issue described in the title.

@sbocconi
Copy link
Author

https://github.com/reinvantveer is working on this:

Yes I'm doing BAG at the moment. Got as far as neatly recursively unpacking
those dreadful zips (at least the Amstelveen test set) , so I can get set
to streaming thise dreadful XMLs to ndjson :)
Greetings,
Rein

@reinvantveer
Copy link

Doing the BAG... 👜

@reinvantveer
Copy link

Dank @jobspierings, je mag me ook assignen als je wil, geloof niet dat ik dat kan...
Of doet @sbocconi dit?

@reinvantveer
Copy link

Downscaling issue to BAG

@reinvantveer reinvantveer changed the title Create content for repositories data-nwb and data-bag Create content for repository data-bag Feb 22, 2016
@reinvantveer reinvantveer removed their assignment Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants