You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So the task here is to add test cases for the already parameterized tests using this example, in test_tile.py and test_draw.py, and then possibly to fix the handling of the shape to return a 2-dim image without color channels in that case.
The text was updated successfully, but these errors were encountered:
It looks like the tiles we have in hips-extra are different (single channel) from the ones on the CDS server (3 channel as for other JPEG).
@tboch - I'm assigning this issue to you: please clarify if we need to change our code to handle single-channel JPEG. And if it's not the case, then we should update the example dataset in hips-extra for IRAC4.
@cdeil : the HiPS standard says nothing about the layout of the JPEG tiles, thus we should expect to have 3 channels or a single channel. I think most of the JPEP grayscale tiles are encoded on 3 channels nevertheless.
In the very case you mention, I'm quite surprised that we have a mix between 1-channel and 3-channels tiles.
Just now I noticed that there are HiPS JPEG tiles that are grayscale, i.e. don't have the 3 color channels. Example:
I think that currently we don't process those correctly, because here we assume with JPEG we always have 3 channels:
hips/hips/tiles/tile.py
Line 52 in fce110c
So the task here is to add test cases for the already parameterized tests using this example, in
test_tile.py
andtest_draw.py
, and then possibly to fix the handling of the shape to return a 2-dim image without color channels in that case.The text was updated successfully, but these errors were encountered: