Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GML 3.2.2 mappings #201

Open
samuel-girard opened this issue Oct 2, 2018 · 8 comments
Open

GML 3.2.2 mappings #201

samuel-girard opened this issue Oct 2, 2018 · 8 comments
Assignees

Comments

@samuel-girard
Copy link

Hi @highsource

I have been trying to generate GML 3.2.2 mappings using jsonix-schema-compiler, but I faced multiple errors, similar to what I read in highsource/jsonix#22

Is there an easy way to generate this version, as you did for the previous 3.2.1 version?
From what I read in the issue, it seems that you did some manual work in order to do it. Anything that we can reproduce?

Thanks.

@highsource
Copy link
Owner

I'll take a look. Normally OGC schemas need some cutomization, but you always have too look at details.

Do you happen to have some sample XML files you could contribute for testing?

@highsource highsource self-assigned this Oct 2, 2018
@samuel-girard
Copy link
Author

Thanks for your quick answer.
I'll check if I can have some samples I can share (we need it in a WPS 2 context).
One information that might be useful: the version 3.2.2 is actually located in http://schemas.opengis.net/gml/3.2.1/ (they overwrote 3.2.1 with 3.2.2 as it is just a "corrigendum" of 3.2.1)

@samuel-girard
Copy link
Author

Here is an example of WPS request including a GML part that should pass with 3.2.2 but does not in 3.2.1:

<?xml version="1.0" encoding="UTF-8"?>
<wps:Execute xmlns:wps="http://www.opengis.net/wps/2.0"
			 xmlns:xlink="http://www.w3.org/1999/xlink"
			 xmlns:ows="http://www.opengis.net/ows/2.0"
			 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
			 service="WPS" version="2.0.0" response="document" mode="sync">
	<wps:Input id="polygone">
		<wps:Data mimeType="text/xml">
			<LinearRing srsName="EPSG:4326" xmlns="http://www.opengis.net/gml/3.2">
				<coordinates>-0.631235,46.307557 -0.262215,46.577225 0.106805,46.477874 -0.631235,46.307557</coordinates>
			</LinearRing>
		</wps:Data>
	</wps:Input>
</wps:Execute>

@highsource
Copy link
Owner

GML 3.2.2 imports ISO 19139 which imports GML 3.2.1.
Which uses the same namespaces as GML 3.2.2.

Which effectively gives a lot of conflicts.

I'm not sure how to solve this.

highsource added a commit that referenced this issue Feb 1, 2019
@highsource
Copy link
Owner

@samuel-girard I have updated GML 3.2.1 schemas. So actually GML 3.2.1 is GML 3.2.2 now.
Could you please check out/build and give it a try?

I consider renaming 3.2.1 simply to 3.2. I think it is better to have 3.2 to represent 3.2.2 vs. 3.2.1 to represent 3.2.2.

highsource added a commit that referenced this issue Feb 1, 2019
@highsource
Copy link
Owner

After some consideration, I will go forward and rename GML 3.2.1 artifacts to GML 3.2. This includes:

  • Maven module: gml-v_3_2_1 -> gml-v_3_2.
  • Java package: net.opengis.gml.v_3_2_1 -> net.opengis.gml.v_3_2.
  • JS module: GML_3_2_1.js -> GML_3_2.js.
  • JSON Schema: GML_3_2_1.jsonschema -> GML_3_2.jsonschema.

This will be a breaking change so I'll have to bump version to 3.0.0.

highsource added a commit that referenced this issue Feb 1, 2019
highsource added a commit that referenced this issue Feb 1, 2019
@highsource
Copy link
Owner

@samuel-girard Please give the current snapshot a try.

@highsource highsource reopened this Feb 1, 2019
@samuel-girard
Copy link
Author

Hi @highsource

I am not working on this part anymore, but I will let know the people in charge so they can get back to you.
Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants