feat(tokenCreateTransaction): Implement TokenCreateTransaction E2E tests: TCK
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
rwalworth
requested review from
ivaylonikolov7,
SimiHunjan,
0xivanov,
RickyLB,
agadzhalov,
Petyo-Lukanov,
jsync-swirlds,
gsstoykov and
ivaylogarnev-limechain
ivaylogarnev-limechain
force-pushed
the
00231-tck-implement-json-rpc-method-for-tokencreatetransaction
branch
from
a42c641
to
0bc413e
Compare
0xivanov
reviewed
Oct 10, 2024
0xivanov
reviewed
Oct 10, 2024
0xivanov
reviewed
Oct 10, 2024
…O, removed the TokenType enum and other minor things Signed-off-by: ivaylogarnev-limechain <[email protected]>
I am okay with switching to just comparing raw keys, though we should do this for all key comparisons in all tests. I created an issue to track this #257 |
…efix for KeyList Signed-off-by: ivaylogarnev-limechain <[email protected]>
…d the returned from the test key Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
…plement-json-rpc-method-for-tokencreatetransaction Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
ivaylogarnev-limechain
force-pushed
the
00231-tck-implement-json-rpc-method-for-tokencreatetransaction
branch
from
d304ea6
to
f1ed3fa
Compare
…tionality and commented out every uint64 test, also synced with 00257 Signed-off-by: ivaylogarnev-limechain <[email protected]>
…ncreatetransaction
Signed-off-by: ivaylogarnev-limechain <[email protected]>
rwalworth
commented
Oct 18, 2024
|
Key comparison and large integer value changes are now working with the C++ SDK! |
…ommented out 2 problematic tests Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
… changes, commented code deleted, re-numbered all tests Signed-off-by: ivaylogarnev-limechain <[email protected]>
…ncreatetransaction Signed-off-by: ivaylogarnev-limechain <[email protected]>
gsstoykov
approved these changes
Oct 22, 2024
0xivanov
approved these changes
Oct 22, 2024
rwalworth
deleted the
00231-tck-implement-json-rpc-method-for-tokencreatetransaction
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the
TokenCreateTransactiontests documented intest-specifications/token-service/tokenCreateTransaction.md. Currently three tests are skipped because of a bug in the services code which allows for tokens to be created with a custom fee that collects to a deleted account. Another test is skipped becausedeleteTokenis not yet implemented.Related issue(s):
Fixes #231 #244
Checklist