feat(accountUpdateTransaction): Implement AccountUpdateTransaction E2E tests: TCK
#224
+1,093
−311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to use as a model going forward. Create utility.md file to hold miscellaneous JSON RPC functions. Move tests and test specifictions documents to folders for the specific Hedera service they are for Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…ion is now contained in accountCreateTransaction.md Signed-off-by: Rob Walworth <[email protected]>
…ix alias only being able to be an ECDSAsecp256k1 key. Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…ts for receiver signature required, auto renew period, and memo Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…-tests-tck Signed-off-by: Rob Walworth <[email protected]>
…tests as implemented Signed-off-by: Rob Walworth <[email protected]>
… tests for declineStakingRewards. Some generateKey calls didn't have a type when they should. Signed-off-by: Rob Walworth <[email protected]>
…t variable name for maxAutoTokenAssociations. Use correct bounds for maxAutoTokenAssociations Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…spec Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…local node testing Signed-off-by: Rob Walworth <[email protected]>
thenswan
reviewed
Jul 22, 2024
Signed-off-by: Rob Walworth <[email protected]>
…ountupdatetransaction
Signed-off-by: Rob Walworth <[email protected]>
…ciation changes as that was moved to v0.53 Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
0xivanov
reviewed
Aug 5, 2024
0xivanov
reviewed
Aug 5, 2024
… into 00217-tck-implement-json-rpc-methods-for-accountupdatetransaction
0xivanov
reviewed
Aug 6, 2024
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…ountupdatetransaction
0xivanov
reviewed
Aug 7, 2024
Co-authored-by: Ivan Ivanov <[email protected]> Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
0xivanov
reviewed
Aug 8, 2024
0xivanov
reviewed
Aug 8, 2024
…tus for invalid staking ID test Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
0xivanov
approved these changes
Aug 19, 2024
ivaylogarnev-limechain
approved these changes
Sep 9, 2024
|
All tests are passing in JS. |
rwalworth
deleted the
00217-tck-implement-json-rpc-methods-for-accountupdatetransaction
branch
ivaylogarnev-limechain
added a commit
that referenced
this pull request
Oct 4, 2024
…E2E tests: TCK (#224) Signed-off-by: Rob Walworth <[email protected]> Signed-off-by: Rob Walworth <[email protected]> Co-authored-by: Ivan Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the tests documented in test-specfications/crypto-service/accountUpdateTransaction.md. Since some of the work was already done for
AccountUpdateTransactiontests, this reworks those tests to match what is in the test specifications, in addition to adding any new tests. The docs were also updated to mark the tests as implemented.Reminder, according to the development process we have established for the TCK (#202), this SHOULD NOT be approved by an SDK lead until their SDK has done any development required to run these tests against their SDK and those tests have passed. Feel free to provide comments and input to the PR, but approvals should not be granted until testing has occurred.
Issues opened in SDKs that encompass the SDK server work should be linked back to the TCK's
AccountUpdateTransactiondevelopment issue (#39) for easy tracking.The work in this PR also consumes the work required for #196.
Related issue(s):
Fixes #217
Checklist