added defrost force flag for processing 3rd grade dependent class files #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hielkehoeve
requested changes
Feb 28, 2020
| @@ -4,7 +4,7 @@ | |||
| <parent> | |||
| <groupId>nl.topicus.plugins</groupId> | |||
| <artifactId>javassist-maven-plugin-parent</artifactId> | |||
| <version>2.2-SNAPSHOT</version> | |||
| <version>2.2.1-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Please make this 2.2-SNAPSHOT
| @@ -4,7 +4,7 @@ | |||
| <parent> | |||
| <groupId>nl.topicus.plugins</groupId> | |||
| <artifactId>javassist-maven-plugin-parent</artifactId> | |||
| <version>2.2-SNAPSHOT</version> | |||
| <version>2.2.1-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Please make this 2.2-SNAPSHOT
| if (forceDefrost) { | ||
| error("FORCE DEFROSTING "+candidateClass.getName()); | ||
| candidateClass.defrost(); | ||
| candidateClass.defrost(); |
There was a problem hiding this comment.
This code will never be reached as line 98 checks for frozen classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project which fails when processing jar'ed files. This is crucial to me since I need to modify a 3rd party lib (annotation enrichment). Please, could you pull the changes and deploy it on central?
Regards,
Marcus