Axxerion #5
Open
Axxerion #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can occur when a project is built that does not compile code but where the plugin is used through a parent pom.
Previously the plugin instrumented only class files in the dependencies. Now it loads all the classes in the compile class path but instruments only the class files that are compiled in local maven project.
hielkehoeve
requested changes
Feb 28, 2020
| final List<String> classpathElements = getCompileClasspathElements(); | ||
| loadClassPath(originalContextClassLoader, | ||
| generateClassPathUrls(classpathElements)); | ||
| transform(Arrays.asList(project.getBuild().getOutputDirectory())); |
There was a problem hiding this comment.
I assume you have a "inline setup" in which you define maven-javassist-plugin in the project directly in order to replace the compiled classes with the altered version.
Your change does not take into account that the maven-javassist-plugin can also be used in a separate project so the altered classes are bundled in a separate jar. (See README.md)
hielkehoeve
requested changes
Feb 28, 2020
| private List<String> getCompileClasspathElements() | ||
| throws DependencyResolutionRequiredException { | ||
| List<?> ret = project.getCompileClasspathElements(); | ||
| ret.remove(project.getBuild().getOutputDirectory()); |
There was a problem hiding this comment.
This works for both type of setups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified the plugin.
Previously the dependencies were instrumented but not the java classes compiled by the local java project.