Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable User to Pin Token in any Community #9898

Closed
dillchen opened this issue Nov 13, 2024 · 4 comments · Fixed by #10164
Closed

Enable User to Pin Token in any Community #9898

dillchen opened this issue Nov 13, 2024 · 4 comments · Fixed by #10164
Assignees
Labels
5 Few days task enhancement New feature or request refinement

Comments

@dillchen
Copy link
Contributor

Description

A community should be able to pin a token in any community, even if not the launchpad community (for example 1inch).

Once admins pin the token, users should be able to swap in and out of the asset using the Uniswap Modal.

Project Owner

No response

Bucket ID

No response

User Stories / Acceptance Criteria

  • Admin is able to pin token from the integration page
  • User is able to swap using Use Uniswap trade widget for post-launchpad phase #9887, it should default to a pool address that is ETH - [asset], and on the chain that the community is deployed on.
  • User is able to to see in sidebar the token that has now been pinned.

Design Devlink

Admin Flow Figma: https://www.figma.com/design/1b9wbqv9YV2FlU2svFyf0I/IdeaCoin?node-id=830-44750&t=HTEIkJjSlAt79J10-4

Swap Flow (same as #9887)

Design Screenshot

image

Additional Context

No response

@dillchen dillchen added this to the ERC20 Launchpad milestone Nov 13, 2024
@mzparacha mzparacha added 3 Full day task and removed needs estimate labels Dec 4, 2024
@timolegros
Copy link
Collaborator

timolegros commented Dec 6, 2024

Per request from @mzparacha: platform work here includes:

  • Rename Tokens table/model to LaunchpadTokens
  • Create a new Tokens table which maps external tokens to communities
  • Create new query route to get these tokens
  • (potentially) Add "supported chains" according to Alchemy Transfers API supported chains intersection with Uniswap deployments

@dillchen will transactions of these tokens be included in the My Transactions page? If so it may be best to limit chains to those supported by Alchemy Transactions API otherwise we will 100X the number of transactions we index internally (might then need to handle CE/Postgres scaling issues).

@mzparacha
Copy link
Contributor

mzparacha commented Dec 6, 2024

A few questions

  1. Only Ethereum communities can pin tokens?
  2. Only 1 external token can be pinned to a community?
  3. When a token is pinned to community, what are the management options for the admin? Can admin remove the pinned token or add a different token?
image
  1. Can a community have a pinned token and a community token at the same time? If only 1 token is allowed the what happens if a token community admin wants to pin an external token, do we block him or something?

  2. Where does this link redirect to?

image

cc: @dillchen

@mzparacha mzparacha added 5 Few days task and removed 3 Full day task labels Dec 6, 2024
@timolegros timolegros self-assigned this Dec 6, 2024
@dillchen
Copy link
Contributor Author

dillchen commented Dec 6, 2024

Answer for @timolegros

@dillchen will transactions of these tokens be included in the My Transactions page? If so it may be best to limit chains to those supported by Alchemy Transactions API otherwise we will 100X the number of transactions we index internally (might then need to handle CE/Postgres scaling issues).

Yes. Let's try to limit as much as possible to the Alchemy API surface area

@dillchen
Copy link
Contributor Author

dillchen commented Dec 6, 2024

For @mzparacha

Only Ethereum communities can pin tokens?

For now yes, let's hardcode this in for EVM specific chains (or chains in which we support the swap module for). In short order (early Q1, we want to add support for Solana)

Only 1 external token can be pinned to a community?

Yes

When a token is pinned to community, what are the management options for the admin? Can admin remove the pinned token or add a different token?

They can update it, 1) remove it 2) change to different one

Can a community have a pinned token and a community token at the same time? If only 1 token is allowed the what happens if a token community admin wants to pin an external token, do we block him or something?

No only one token at a time. If there is a launchpad token, then we should allow no pins

Where does this link redirect to?

We will have a doc link, we do not have this yet. We'll update this before launch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Few days task enhancement New feature or request refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants