Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for H2 #929

Open
DavideD opened this issue Aug 4, 2021 · 10 comments · May be fixed by #1336
Open

Add support for H2 #929

DavideD opened this issue Aug 4, 2021 · 10 comments · May be fixed by #1336
Assignees
@DavideD
Labels
enhancement New feature or request

Comments

@DavideD
Copy link
Member

DavideD commented Aug 4, 2021

For testing and examples, it would be nice to have support for an in-memory database like H2.

There is actually an example in the Vert.x SQL Client documentation on how to wrap the H2 JDBC driver around the Vert.x Pool: https://vertx.io/docs/vertx-jdbc-client/java/#_using_the_sql_client_api
@DavideD DavideD changed the title Support on in-memory database Support an in-memory database (H2 for example) Aug 4, 2021
@gavinking gavinking added the enhancement New feature or request label Sep 4, 2021
@DavideD DavideD mentioned this issue Jan 14, 2022
Closed
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 17, 2022
@blafond
[hibernate#929] Draft - Initial changes for H2 db support
1e04a1d
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 18, 2022
@blafond
[hibernate#929] added rule to skip H2 DB
bd9aab9
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 18, 2022
@blafond
[hibernate#929] filled out H2 client pool
279d537
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 18, 2022
@blafond
[hibernate#929] added test for H2 connectivity
da17971
@blafond blafond self-assigned this Mar 18, 2022
@cj848
Copy link

cj848 commented Mar 20, 2022 •
edited
Loading

@blafond, @DavideD
Hello. I am a developer of kotlin-jdsl.
Hibernate-reactive does not officially support h2 db, so I went in after seeing the above issue and changed the settings to test internally using h2 db. I hope it will be helpful for your development.

For reference, when I run h2 db in hibernate-reactive, I have summarized the following problems and the progress to solve them.

  1. Schema generation is not possible because h2 db is not supported.
  2. There was no db pool, but VertxH2DBConnectionPoolConfiguration
    solved using code
  3. In case 1, it induces query generation using the existing hibernate-core's ddl schema generator syntax - Since h2 db itself is not supported, it is modified to operate in mysql mode.

please note. We expect to support H2 DB quickly.
I tried to contribute, but it was a lot more work than I expected, so I'm sharing the difficulties I've been through.

Thank you for making such a good library, I'm using it well.

@DavideD
Copy link
Member Author

DavideD commented Mar 20, 2022 •
edited
Loading

Thanks @cj848, we are currently working on it. Not sure at the moment how long is gonna take to support h2 because we often need some additional work to make the Hibernate ORM Dialect works with the Vert.x driver. We might be able have something working (with some limitations) in the next couple of weeks.

Anyway, people seems very interested to this feature so we will try to keep it up to date.

Cheers

@cj848
Copy link

cj848 commented Mar 20, 2022

@DavideD
Thank you for your interest.
I am using this library in a reactive module inside a library called kotlin-jdsl as in the link in the previous comment. I am very grateful that I can use reactive while using the features of JPA as it is. All of the hibernate-reactive contributors worked hard in the development. thank you

@DavideD DavideD changed the title Support an in-memory database (H2 for example) Add support for H2 Mar 21, 2022
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 22, 2022
@blafond
[hibernate#929] H2 client pool and build dependencies
2f3e31b
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 22, 2022
@blafond
[hibernate#929] Added H2 database for testing
d6ccac7
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 22, 2022
@blafond
[hibernate#929] Modifications to tests to accommodate or skip H2 tests
9bc6b57
@blafond blafond mentioned this issue Mar 22, 2022
Closed
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 25, 2022
@blafond
[hibernate#929] minor fixes
4c11a7f
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 25, 2022
@blafond
[hibernate#929] initial hibernate-reactive-h2 module
07fcb41
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Mar 28, 2022
@blafond @DavideD
[hibernate#929] H2 client pool and build dependencies
d15360b
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Mar 28, 2022
@blafond @DavideD
[hibernate#929] Added H2 database for testing
20dbfd9
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Mar 28, 2022
@blafond @DavideD
[hibernate#929] Modifications to tests to accommodate or skip H2 tests
e64246b
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Mar 28, 2022
@blafond @DavideD
[hibernate#929] minor fixes
8c0bc92
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Mar 28, 2022
@blafond @DavideD
[hibernate#929] initial hibernate-reactive-h2 module
9f6ee8a
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 29, 2022
@blafond
[hibernate#929] hibernate-reactive-h2 module
614428d
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 29, 2022
@blafond
[hibernate#929] build changes for h2 module
c2eb3f7
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 29, 2022
@blafond
[hibernate#929] Adapting H2SqlClientPool
0702ecd
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 29, 2022
@blafond
[hibernate#929] Adapted tests to exclude H2 dialect
640613e
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 30, 2022
@blafond
[hibernate#929] Adapted tests to exclude H2 dialect
fe8ede8
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 31, 2022
@blafond
[hibernate#929] hibernate-reactive-h2 module
124e8c7
blafond added a commit to blafond/hibernate-reactive that referenced this issue Mar 31, 2022
@blafond
[hibernate#929] H2 module integration
94c2703
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@blafond @DavideD
[hibernate#929] hibernate-reactive-h2 module
7c33cc9
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] H2
bfe4110
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Add H2Database
85e1183
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Adapt or disable existing tests for H2
663598d
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Add H2 to the GitHub workflows
ae5a255
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Refactor id generation for MySQL
0e76e87 
MySQL always returns an id of type Long.
This commit changes an hack that was affecting all dbs
and preventing H2 to read identity id of type Integer or Short
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@blafond @DavideD
[hibernate#929] hibernate-reactive-h2 module
e3a0d60
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] H2
0e68c23
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Add H2Database
8115201
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Adapt or disable existing tests for H2
58ff69e
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Add H2 to the GitHub workflows
7b4f29a
@DavideD
Copy link
Member Author

DavideD commented Jun 14, 2022

We stopped working on this one because the results were unstable. When we have time we should have another look at it

It turns out that I'm not very smart and didn't realize that we were using the wron URL. The current PR looks promising: #1336

DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Refactor id generation for MySQL
5ab582b 
MySQL always returns an id of type Long.
This commit changes an hack that was affecting all dbs
and preventing H2 to read identity id of type Integer or Short
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@blafond @DavideD
[hibernate#929] hibernate-reactive-h2 module
efd2951
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] H2
840eb44
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Add H2Database
de4a47d
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Adapt or disable existing tests for H2
eed8d7e
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 14, 2022
@DavideD
[hibernate#929] Add H2 to the GitHub workflows
cb8c33c
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@DavideD
[hibernate#929] Refactor id generation for MySQL
dd649e1 
MySQL always returns an id of type Long.
This commit changes an hack that was affecting all dbs
and preventing H2 to read identity id of type Integer or Short
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@blafond @DavideD
[hibernate#929] hibernate-reactive-h2 module
15558b0
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@DavideD
[hibernate#929] H2
26ce988
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@DavideD
[hibernate#929] Add H2Database
9ffbab1
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@DavideD
[hibernate#929] Adapt or disable existing tests for H2
148ec7c
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@DavideD
[hibernate#929] Add H2 to the GitHub workflows
d2b37ab
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@DavideD
[hibernate#929] Refactor id generation for MySQL
bff1835 
MySQL always returns an id of type Long.
This commit changes an hack that was affecting all dbs
and preventing H2 to read identity id of type Integer or Short
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@blafond @DavideD
[hibernate#929] hibernate-reactive-h2 module
0a4946e
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@DavideD
[hibernate#929] H2
4888ea2
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@DavideD
[hibernate#929] Add H2Database
4794c78
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@DavideD
[hibernate#929] Adapt or disable existing tests for H2
13dbccc
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jun 22, 2022
@DavideD
[hibernate#929] Add H2 to the GitHub workflows
6ebda19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integration with H2 DavideD/hibernate-reactive
Add support for H2 blafond/hibernate-reactive
5 participants
@DavideD @blafond @gavinking @mkouba @cj848