Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Renaming get_equipment Method for Clarity #1321

Open
2 tasks done
jknndy opened this issue Oct 22, 2024 · 0 comments
Open
2 tasks done

Consider Renaming get_equipment Method for Clarity #1321

jknndy opened this issue Oct 22, 2024 · 0 comments
Labels

Comments

@jknndy
Copy link
Collaborator

jknndy commented Oct 22, 2024

Pre-filing checks

  • I have searched for open issues that report the same problem
  • I have checked that the bug affects the latest version of the library

Related to discussion in #1279 .
The get_equipment method could benefit from a more descriptive name. Currently the method de-duplicates and preserves the order of the list which isn't exactly equipment related.

Some potential new names:

  • deduplicate_ordered_list
  • deduplicate_preserve_order (I'm partial to this one if the functionality remains the same)
  • serialize_list_to_tags

I could find 3 instances where the functionality maintaining the order is required (argiro, beyondfrosting & glutenonashoestring). This could easily be implemented directly into each individual scraper or functionality could remain on the 29 current scrapers that contain the function as a "safety" feature for instances where untested pages contain duplicate items in their list.

@jknndy jknndy added the bug label Oct 22, 2024
@jknndy jknndy changed the title Consider Renaming and Refactoring get_equipment Method for Clarity and Efficiency Consider Renamingget_equipment Method for Clarity Oct 22, 2024
@jknndy jknndy changed the title Consider Renamingget_equipment Method for Clarity Consider Renaming get_equipment Method for Clarity Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant