Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can i use this package with ftp protcol #19

Open
abdolrhman opened this issue Oct 21, 2019 · 6 comments
Open

can i use this package with ftp protcol #19

abdolrhman opened this issue Oct 21, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@abdolrhman
Copy link

can i download files with ftp protocol instead of http ?

@hgouveia
Copy link
Owner

@abdolrhman at the moment does not support FTP, I will consider adding support in future releases

@hgouveia hgouveia self-assigned this Oct 23, 2019
@hgouveia hgouveia added the enhancement New feature or request label Oct 23, 2019
@abdolrhman
Copy link
Author

I could help you with implementing FTP ...
I need to have this functinality for node-ftp,
as there is no ftp node package that implement this functialities .
what do u think ?

@hgouveia
Copy link
Owner

I could help you with implementing FTP ...
I need to have this functinality for node-ftp,
as there is no ftp node package that implement this functialities .
what do u think ?

I was checking this possibility earlier today but I didn't find a simple way of implementing using just native node.js since one of the goals of this library is not to have dependencies. Is possible to implement it completely native but I will end up creating an entire FTP client because you need to take in consideration a lot of scenarios, for example, Authorization, FTPS, TLS, etc

after some consideration, I think if any user needs to use FTP is better just to use node-ftp directly or another library that provides this functionality, I also was considering to have "plugins system" and this could be a plugin

@abdolrhman
Copy link
Author

so your thinking to create a plugin for node-ftp or for any package that implements this protocl,
as for implememinting this functionalites ?
because i was thinking to do the same, till i saw your package.
so i thought we could close the gaps and create some thing similar for ftp

@hgouveia
Copy link
Owner

hgouveia commented Oct 23, 2019

so your thinking to create a plugin for node-ftp or for any package that implements this protocl,
as for implememinting this functionalites ?
because i was thinking to do the same, till i saw your package.
so i thought we could close the gaps and create some thing similar for ftp

I was thinking more the possibility to add a plugin/middleware system to this library,

something like

const { DownloaderHelper } = require('node-downloader-helper');
const ftpPlugin = require('node-downloader-helper/ftp-plugin');
const dl = new DownloaderHelper('ftp://www.ovh.net/files/1Gio.dat', __dirname);

dl.use(ftpPlugin({user, pass, secure:true /*...more opts*/ )); // or DownloaderHelper.use(ftpPlugin);
dl.on('end', () => console.log('Download Completed'))
dl.start();

and basically will use ftpPlugin to handle the 'download' operation, and this can bring more possibilities to extended it

ftpPlugin could be just a wrapper of node-ftp to handle the download only, since we don't need to care about upload

@abdolrhman
Copy link
Author

that would be a fantastic thing,
because from where i see , there is no package at all that implement the download from ftp with respect for (stop/ resume/ cancel ) the download,
implementing this will change the game,
And i think will attract alot of people,
because download by ftp is more secure and better than download from http.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants