export internal API for user customisations #21
Conversation
- export createMappedSelectorCreator, memoizeMap & memoizeList - add relevant TypeScript typings
|
@heyimalex Have you had a chance to look at it? |
| import { | ||
| Iterable, | ||
| List | ||
| } from "immutable"; | ||
|
|
There was a problem hiding this comment.
Does this create a hard dependency on immutable?
There was a problem hiding this comment.
Oh yeah, I think it does - is that a problem?
There was a problem hiding this comment.
@heyimalex hi, just a friendly reminder ;) would you like me to remove that "hard dependency"?
|
Sorry, I'll take a look tonight! |
|
Bump...? 😄 I guess, the library is already depending on |
|
Sorry, I'll try and find some time soon! RE: Immutable, right now it's a devDependency, so people who |
|
My thoughts on this right now are I can cut a release exposing the functions you need, but adding type definitions seems too difficult. If you want to try and get this running I think it'll take more than what's currently in the pr. |
|
Released 1.0.6, lmk if that solves your problem |
|
Thanks! I should get around to it soon and will let you know! |
|
@heyimalex Did you, by any chance, publish it to NPM but forgot to push it to the repo? |
|
@Domiii Haha my bad, it should be up now |
|
I definitely prefer your solution over this PR, as it is clean and does not suddenly change the entire purpose of the library. Sweet! |
|
@heyimalex I think ideally you might want to consider a separate library with ImmutableJS support (e.g. reselect-map-immutable). I don't think it's possible to add any type definitions for ImmutableJS part of the library otherwise without creating hard dependency on ImmutableJS. |
Resolves #20