Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Theme BP-Gallery #2139

Closed
wants to merge 3 commits into from
Closed

add Theme BP-Gallery #2139

wants to merge 3 commits into from

Conversation

sy-data
Copy link
Contributor

@sy-data sy-data commented Jan 26, 2024 •
edited
Loading

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)
    • Languages:
    • en English
    • ru Russian
    • zh-cn simplified Chinese
    • zh-tw traditional Chinese

Note

No need to translate ko, pt-br, th languages if you submit a PR for documentation.

Warning

ko, pt-br, th languages document are inactive. Please, submit issue if you want to continuous contribution to them.

@github-actions github-actions bot added infra infrastructure, configuration of this repo Themes _data/themes/ labels Jan 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 26, 2024 •
edited
Loading

Theme name validation passed.
Theme thumbnails validation completed.

uiolee
uiolee requested changes Jan 26, 2024
View reviewed changes
package.json
@@ -43,4 +43,4 @@
"engines": {
"node": ">=14"
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just add your theme, don't modify package.json.

uiolee
uiolee requested changes Jan 26, 2024
View reviewed changes
source/themes/screenshots/BP-Gallery.png Outdated Show resolved Hide resolved
@sy-data sy-data requested a review from uiolee January 27, 2024 02:00
@sy-data sy-data marked this pull request as draft January 29, 2024 00:34
@sy-data sy-data closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uiolee uiolee Awaiting requested review from uiolee

Assignees
No one assigned
Labels
infra infrastructure, configuration of this repo Themes _data/themes/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sy-data @uiolee