Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The individual-based Markov CTSTM vignette uses a fixed time: is this sensible? #126

Closed
mclements opened this issue Jul 26, 2024 · 3 comments

Comments

@mclements
Copy link
Collaborator

The fifth transition is fixed at one year, which makes sense for a clock-reset transition. However, the one-year transition could be in the past for a Markov model:(. Should we change the transition to being exponential (say)?

Kindly, Mark.

@mclements
Copy link
Collaborator Author

I now see that a point mass is sampled using:

  double trandom(double lower, double upper) const {
    return lower + std::min(est_, upper - lower);
  }

so that this is a constant time in state -- which is arguably clock-reset. Is this the desired semantics? If so, I will close this issue.

@dincerti
Copy link
Member

I think it's the behavior that is most useful and practical. What do you think? It could certainly be better documented though.

@mclements
Copy link
Collaborator Author

Thanks for these comments. Some further documentation would be helpful -- after the pull request:)? I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants