Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Vanilla apps are broken #14

Open
zeke opened this issue Apr 12, 2013 · 6 comments
Open

Vanilla apps are broken #14

zeke opened this issue Apr 12, 2013 · 6 comments

Comments

@zeke
Copy link
Contributor

zeke commented Apr 12, 2013

http://cl.ly/text/3c192d252c0A

I thought it might be the restler dependency of faceplate getting quietly updated to a version with breaking API changes, but restler hasn't been updated in quite some time.

I tried updating faceplate from 0.0.4 to 0.5.0, but that doesn't solve anything: a request to / just hangs and times out.

This callback doesn't get fired: https://github.com/heroku/facebook-template-nodejs/blob/master/web.js#L47

To get up and running with a localhost:5000 OAuth setup:

git clone [email protected]:heroku/facebook-template-nodejs.git
cd facebook-template-nodejs
heroku config:pull -a glacial-falls-8460
npm install
foreman start

Open localhost:5000.

@zeke
Copy link
Contributor Author

zeke commented Apr 14, 2013

After much tinkering, I was able to get the app running. There were two bugs: one in faceplate, one in facebook-template-nodejs. Here are two pull requests that should solve it:

Note: I updated to the latest version of faceplate and edited the vendored faceplace dependency files right inside the template app. Once the faceplate pull request is merged, the template app will need to be updated to the new faceplate version, presumably 0.6.0.

Note2: If you're testing this locally, you may need to (counterintuitively) flip sandbox mode to disabled on your facebook app.

cc @ddollar @jesperfj @mmcgrana @jonmountjoy

@zeke
Copy link
Contributor Author

zeke commented Apr 16, 2013

This has been fixed in #15 and deployed to Heroku, but sandbox mode still needs to be disabled for the app to work:

http://cl.ly/image/2O0c1r0p0S1L

Sandbox is mode is enabled by default. The Youtube screencast in the devcenter article is now out of date, as it doesn't mention this now-necessary step.

@jonmountjoy
Copy link

I've never needed to disable sandbox mode on any other Facebook app before.

Is this new, or just Node.js related? If just Node.js related, you may
need to add some (ugly) caveat to the Facebook
articlehttps://devcenter.heroku.com/articles/facebook

On Tue, Apr 16, 2013 at 10:14 PM, Zeke Sikelianos
[email protected]:

This has been fixed in #15https://github.com/heroku/facebook-template-nodejs/issues/15and deployed to Heroku, but sandbox mode still needs to be disabled for the
app to work:

[image: http://cl.ly/image/2O0c1r0p0S1L]https://a248.e.akamai.net/camo.github.com/c121cce36c95fa87a1d87a0a11c11898c397a02d/687474703a2f2f636c2e6c792f696d6167652f324f3063317230703053314c2f636f6e74656e74232e706e67

Sandbox is mode is enabled by default. The Youtube screencast in the devcenter
article https://devcenter.heroku.com/articles/facebook is now out of
date, as it doesn't mention this now-necessary step.


Reply to this email directly or view it on GitHubhttps://github.com//issues/14#issuecomment-16472231
.

@wobblyrampack
Copy link

Are the vanilla facebook templates still broken? I get an error right away when creating a facebook template app - Cannot read property 'name' of undefined.

@neilmiddleton
Copy link

Received a ticket about this still being broken. Same error as above.

@friism
Copy link

friism commented Jul 10, 2013

There's also a Stackoverflow issue.

The PHP template is not broken out of the box. The issue is fixed when using the node.js template if one disables sandbox mode, as @zeke points out.

Since the PHP template can work without this, I'm sure the node.js one could be made to do the same.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants