Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punctuations marks are not ignored in Urdu #18

Open
victorbnl opened this issue Jun 5, 2021 · 0 comments
Open

Punctuations marks are not ignored in Urdu #18

victorbnl opened this issue Jun 5, 2021 · 0 comments

Comments

@victorbnl
Copy link

victorbnl commented Jun 5, 2021

Disclaimer

⚠️ I don't speak Urdu at all so please don't take directly in account what I say and ask a real Urdu speaker ⚠️

Issue

But there seem to be some characters that should be ignored in Urdu :
https://github.com/hermitdave/FrequencyWords/blob/master/content/2018/ur/ur_full.txt

See lines 3 and 5

What makes me think these are not words but really punctuation as someone who doesn't speak Urdu are the characters' name :
ARABIC COMMA and ARABIC FULL STOP

Potential fix

If you made sure this is not just me that has not enough knowledge of the language but a real issue, my fix would be to add

،

and

۔

in the ignored characters list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant