Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: Update vm exit handling to be on par with Linux #802

Open
jounathaen opened this issue Nov 21, 2024 · 0 comments
Open

MacOS: Update vm exit handling to be on par with Linux #802

jounathaen opened this issue Nov 21, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed MacOS

Comments

@jounathaen
Copy link
Member

On Linux, all other VM threads are ended, once a single one has completed execution. This solves Uhyve hanging on failures of hermit.

uhyve/src/linux/mod.rs

Lines 134 to 141 in 06d18a1

// Wait for one vCPU to return with an exit code.
barrier.wait();
for thread in &threads {
KickSignal::pthread_kill(thread.as_pthread_t()).unwrap();
}

The macOS code should be updated to be on-par with the Linux version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed MacOS
Projects
None yet
Development

No branches or pull requests

1 participant