-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There might be error in the train_maml function. #6
Comments
Here my attempt to adapt the code. Now ten tasks are performed and summed in each step:
@lishanwu135 I would be glad if you or somebody else can review the code. Note: If you train for more than one epoch, you would also need to improve the loss calculations for this function (maybe that's worth opening another issue). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The loss used for calculating the gradient to perform the meta update is only from one task. However, it should be the sum of all sampled tasks according to the original paper. Please look at step 8 in the code (below). The test_loss is inside the loop for i, t in enumerate(random.sample(dataset, len(dataset))), indicating the test_loss is only for one task.
The text was updated successfully, but these errors were encountered: