Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nbc rebase #602

Open
wants to merge 104 commits into
base: main
Choose a base branch
from
Open

Nbc rebase #602

wants to merge 104 commits into from

Conversation

mdavezac
Copy link

@mdavezac mdavezac commented Nov 5, 2015

see #591

Rupert Nash added 23 commits October 24, 2015 18:44
Add basic wrapping of asynchronous MPI calls
bc112a6
Add a helper function MapAllToAll that takes a std::map keyed on rank…
314fee8 
… and only sends to ranks with associated values.
Factor the NeighbouringDataManager to use the MapAllToAll and fix a b…
483cd77 
…ug in that
Remove AllToAll from the net class hierarchy (as it's unused)
cb881bb
Remove a load of random extra parentheses in the code
0240e8c
Reimplement the StabilityTester with a non-blocking collective
f0ef956
Move the stability tester implementation into an .hpp file
d057876
MAke the StabilityTester use the wrapped MPI async interface
6446e55
Remove the unphysical Mazzeo collisions used in his BCs
a3b63db
Remove some unneeded specialisations of PhasedBroadcast from the vis:…
9b963a9 
…:Control class
remove the DensityTracker class from IncompressibilityChecker
b07157c
Create a CollectiveAction base class and make the IncompressibiltyChe…
9ea2cbd 
…cker use it
Make the IncompressibiltyCHecker unittests pass.
17f369f
Actually register the IncompressibilityChecker to do it's communication
f7cb9cc
Make the StabilityTester a CollectiveAction
b558efa
Make the EntropyTester a CollectiveAction instead of a PhasedBroadcast
679dbc8
Make the steering data distribution object (SteeringComponent) a Coll…
9c0a7b8 
…ectiveAction
Remove the PhasedBroadcastRegular class template as it's unused.
cac78c8
Organise the timers used by the CollectiveActions in the monitoring.
305cc19
Avoid the use of C++11 extensions to the standard library vectors (cb…
0f09679 
…egin and cend member functions)
Record Archer configuration options in fabric
63d7f8e
Ensure that the MPI_Wait calls of the CollectiveActions are timed by …
075df29 
…the mpiWait timer
Fix the debugger start up on OSX Yosemite
384bedb
@mdavezac
Copy link
Author

mdavezac commented Nov 5, 2015

This is just to see if I can use anything for the RBC branch

@rupertnash
Copy link
Member

retest this please

@mdavezac
Copy link
Author

Should we merge this then?

@rupertnash
Copy link
Member

No, because I need to implement the switch from wait to test outlined in #590. The version as-is hurts single core and scaling performance.

@rupertnash
Copy link
Member

This PR will close #647

@rupertnash
Copy link
Member

@mdavezac I'd appreciate it if you could have a glance at the problem with MPI+cmake on Legion+GNU. It is certainly possible there's an issue in the mpi.cmake file that checks there is MPI 3.0 available. I'm just going to check this on ARCHER

@rupertnash
Copy link
Member

For some reason this was stalled in Jenkins on the simulation shut down. Works fine on my MacBook, so retest this please to find out if this is just a one off.

@rupertnash
Copy link
Member

Pleased to say that unit and regression tests are passing on ARCHER. Gonna test scaling now.

@rupertnash
Copy link
Member

retest this please

@mdavezac
Copy link
Author

@rupertnash, the hand-rolled MPI version thingie breaks on legion with openmpi 1.8.4 (and gcc). It corresponds to version 3.0. Are you sure you need to roll out your own FindMPI + extra script?

@mdavezac
Copy link
Author

I'm not too keen on investigating why hand-rolled stuff breaks :(
Unless it's my own hand-rolled crap :)

@rupertnash rupertnash changed the base branch from master to main September 30, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rupertnash rupertnash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdavezac @rupertnash @mobernabeu @jenshnielsen