JLS Upgrades

[frostyfan109]

• Long polling on server extension endpoints (course, student, assignments, current assignment)
  • This is a nice change in general, but I added this particularly as a fix for the bug where when the page first loads, it may say you aren't in the student repository for a few seconds (hlx2-118)
• File change tracking
• Move file changes/submissions into a tab group to save vertical space (I also added a tabs implementation to the codebase which we'll probably end up needing in JLP extension as well based on its similar size constraints)
• Assignment status tags
  • For past assignments, "Submitted <time> ago" or "<time> past due"
  • For active assignments, "Submitted" or "Not Submitted"
  • For future assignments, "Upcoming"
  • A "low time" tag also shows up next to the status tag when the assignment closes in the next 4 hours, with text "Due in <time>"
• Past due warning
• Submission button tooltip explains why submission is disabled (if disabled) when hovered over.

Misc:

• Polished some stylesheets
• Fix a couple remnants that got missed in the rename PR
• Remove .env and update the .env.sample with an up-to-date example

[Hoid]

There's some discrepancies here from the wireframes that I personally think should be changed. You have a section here with Student, Instructor, and Due Date and also have "Summary" and "Description" text boxes when neither are in the wireframes and aren't necessary. I could see an argument for putting a more explicit Due Date in a tooltip when you hover over the "Due in 2 Hours" item though, but not the rest of the stuff you have. We can autogenerate the commit message and descriptions for users - we want to abstract away the git behavior as much as possible.

I'll take a closer look at the code later but those are the first things I noticed.

[frostyfan109]

There's some discrepancies here from the wireframes that I personally think should be changed. You have a section here with Student, Instructor, and Due Date and also have "Summary" and "Description" text boxes when neither are in the wireframes and aren't necessary. I could see an argument for putting a more explicit Due Date in a tooltip when you hover over the "Due in 2 Hours" item though, but not the rest of the stuff you have. We can autogenerate the commit message and descriptions for users - we want to abstract away the git behavior as much as possible.

I'll take a closer look at the code later but those are the first things I noticed.

Yeah, as I've told Chuck, I'm not following the wireframes to a tee (this is especially true for JLS since we already have an established UI), which is why I attached the screenshots to discuss in this PR. Let me also add here that David's wireframes are not "complete" in the sense that he didn't design them for us to replicate 1:1 as our exact UI; they're more so a starting design and guide (at least IMO).

Yes we have student and instructor sections when neither are in the wireframe. I would argue that instructors is useful. This can be a good place to display email/contact, as a tooltip, or something. Basically, this section was intended as a "how to get help with the assignment if you need it". I agree the student section is useless. I originally added it as a placeholder for vertical whitespace. I didn't remove it because there was no need to, and I think it looks nice, but I don't have any issue with removing it.

Due date section absolutely should be included regardless of it's in the wireframe, not sure what your point is about that. There already is an explicit tooltip when hovering over the "due in" tag. But that tag only displays as a warning when the assignment is due within 4 hours. There needs to be a clear, explicit date/time that the assignment closes displayed to the student. They shouldn't have to look around or hover over stuff for it.

The summary/description cannot be autogenerated, I don't know what you mean by that? Also it doesn't mention git. That is just the submission summary/description, which just translates into the standard git commit message format. The description is optional.