Bug: "Nested" module replacement not working as expected

[twjacobsen]

Description of the bug

When using MockBuilder to replace a module import with a "testing module", that in turn imports some other "testing module" is not working as expected. The declarations of the sub-testing-module is not made available in my tests

An example of the bug

Link: https://stackblitz.com/edit/github-fvnrfv?file=src/test.spec.ts

Expected vs actual behavior

Expected behaviour: The component in the test renders as name: sandboxt one testing two

Actual behaviour: The component in the test renders as name: sandboxt one two, indicating the nested module declarations are not used

Brief of the code structure:
Component imports Sub1Module which declares Component1 and imports Sub2Module. Sub2Module declares Component2.

In test, Sub1Module is replaced with Sub1TestingModule, which declares Component1 but imports Sub2TestingModule. Sub2TestingModule declares ComponentTesting2.

The selectors of Component2 and ComponentTesting2 are identical.

We've been using this pattern for regular non-standalone component testing, where we usually provide all module imports manually to the test. We've started using MockBuilder for standalone component testing, since it's very convenient - but this one issue is a pretty big deal to us :(

[satanTime]

Hi @twjacobsen,

thanks for the report.

A failing example: https://github.com/satanTime/ng-mocks/blob/issues/4486/tests/issue-4486/angular.spec.ts

[twjacobsen]

Thanks for "correcting" the test.

I'm having a hard time reading in the docs, if it's possible to replace a submodule using MockBuilder. Ie. instead of creating Sub1TestingModule in my example, would it be possible to do MockBuilder().keep(Sub1Module).replace(Sub2Module, Sub2TestingModule)? It does not look as if it's possible.

[satanTime]

Hi @twjacobsen,

what you do is expected and is exactly how the .replace works.
However, it turned out to be a bug in angular itself.

I've submitted a bug here: angular/angular#48432

[twjacobsen]

Thanks a lot for finding that. I'll follow these issues closely :)

[satanTime]

Hey @twjacobsen,

Thanks for the update.
Stay in touch then!

[dtomaszewski]

hi @satanTime I see there is test PR, any chance for some progress ?

[satanTime]

Hi @dtomaszewski, it's still blocked on Angular's side: angular/angular#48432