Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent recording area if display settings are changed when the app is open #84

Open
amit-chaudhari1 opened this issue May 13, 2024 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@amit-chaudhari1
Copy link
Contributor

amit-chaudhari1 commented May 13, 2024

Description

Changing the scaling factor for the display when the app is in system tray will introduce inconsistent recording areas and positions.

Reproducible steps

  1. start the app
  2. record the screen, it records properly
  3. change the scaling on the display settings
  4. now record after invoking again . (record a sanely large area) it should mess up the area and the positions.

Possible Solution

scale_factor can be a dynamic var or we could shift the spawn to record scale_factor only on invoking cmd shift 2 (or ctrl shift 2)

Notes

  • I've have only tested this in dev build , not in production.
  • This behavior will probably go away when we eventually roll out multi monitor support, so i think we should look into this after that.
@clearlysid clearlysid added bug Something isn't working labels May 13, 2024
@clearlysid clearlysid changed the title Changing the display settings when the Inconsistent recording area if display settings are changed when the app is open May 15, 2024
@clearlysid clearlysid added the help wanted Extra attention is needed label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants