Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proccesses.app Weird disk partition #210

Open
louies0623 opened this issue Sep 16, 2023 · 7 comments
Open

Proccesses.app Weird disk partition #210

louies0623 opened this issue Sep 16, 2023 · 7 comments

Comments

@louies0623
Copy link
Contributor

20230916_185703
20230916_185641
Too many disk partitions appear, as the picture.

@probonopd
Copy link
Member

probonopd commented Sep 17, 2023

Not all of these are partitions indeed. @Hierosme can you have a look please?
Why does the Processes app even deal with partitions at all?

@Hierosme
Copy link

Hierosme commented Sep 19, 2023

Hello,

i'm in travel yet i cant touch my IDE before next week.

Why does the Processes app even deal with partitions at all?

As you havent say to me, that a Activity Monitor clone, the original Activity Monitor got it Disk Usage tab, then the Proccesses.app got...

image

About the anormal disk partition number:
The trouble is psutil under FreeBSD specific , that trouble do not exist under GNU/Linux...

giampaolo/psutil#906
https://github.com/giampaolo/psutil/blob/77e5b7445748d30d22c0e3b2e651414da96a88b4/psutil/_psbsd.py#L366

Here the code where i use psutil.disk_partitions(all=False):

for part in psutil.disk_partitions(all=False):

Yes that a bug on our data source ....

@Hierosme
Copy link

i can a a filter easilly and force that match with df and not df -a.

I open a PR for a workarround soon.

@Hierosme
Copy link

Hierosme commented Sep 26, 2023

i have put micro filter inside the #209

It consist to consider to display only pratition it got more of one FS block size.
For speed up i have consider block to 4096.

Actually df and df -a return same result under FreeBSD, that is our root cause.

A good way can be to display only certain type of file system (in cse List to do), yet that is block size filter.
Please can you retry and ask me if the result is more close of what you expect ?
@louies0623 @probonopd

@louies0623
Copy link
Contributor Author

I don't understand this, maybe @probonopd can

@probonopd
Copy link
Member

#209 is merged. So, is it working better now @louies0623?

@Hierosme
Copy link

Hierosme commented Oct 4, 2023

Personally i dont like the workarround.

If df -a under FreeBSD work like that , it certinky because under FreeBSD that is supposate to be display like that.

From my point it should be let like FreeBSD want, then filter nothing.
In general i like say Not my fault here that a hight way to a Not my fault :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants