-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/backups samples with restore #2
base: feature/backups-samples-part-1
Are you sure you want to change the base?
Feature/backups samples with restore #2
Conversation
I'm also getting that same error with deleting a backup from the node samples as well. Pretty sure I had the node samples working at one point so maybe this has changed? Or maybe it's always been a race and I've never hit it before. |
Could you add tbpg@ to this review? |
Please also add @larkee to the repo. |
Sorry, I totally missed this. Yes, you need to wait for the database to finish optimizing before you can delete the backup. |
…mples-with-restore # Conflicts: # spanner/spanner_snippets/snippet_test.go
…o move out of optimizing state.
Added poll loop in the test harness to wait for the restored database to come out of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - minor nits
…mples-with-restore
…mples-with-restore
Added restore sample.
The restore database name is generated similarly to the test database name with a different prefix and similar truncation logic to prevent > 30 character errors.
I have noticed there's some race condition happening with the DB. Sometimes it works, sometimes getting an error:
My best guess is that the optimizing stage is sometimes still ongoing after the restore operation completes which requires the backup to still be present. Do we need to wait for the database state to exit the 'optimizing' state?