Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x Add note to MP performance (and SE?) about using thread pool metrics for monitoring #9531

Open
tjquinno opened this issue Nov 22, 2024 · 0 comments
Assignees
Labels
3.x Issues for 3.x version branch docs enhancement New feature or request P3 performance server

Comments

@tjquinno
Copy link
Member

Environment Details

  • Helidon Version: 3.x
  • Helidon SE or Helidon MP
  • JDK version:
  • OS:
  • Docker version (if applicable):

Problem Description

The MP performance tuning doc page mentions customizing thread pool settings and turning on FINE-level logging so the log output reports the non-default settings.

A good addition to that section would be a brief description of the Helidon-provided thread pool metrics. The ExecutorServiceMetricsObserver class in helidon/metrics/metrics is where metrics are exposed (based on the corresponding methods the Java ThreadPoolExecutor type exposes). The metric naming is straightforward but the tags are a little interesting and will need to be explained because of the need to describe multiple supplier categories, suppliers within them, and pools within suppliers so we'd need to describe that a bit.

  • active-count
  • completed-task-count
  • pool-size
  • largest-pool-size
  • task-count
  • queue
    • remaining-capacity
    • size

Steps to reproduce

Visit the linked page above.

@tjquinno tjquinno added enhancement New feature or request docs 3.x Issues for 3.x version branch performance server labels Nov 22, 2024
@tjquinno tjquinno added this to Backlog Nov 22, 2024
@github-project-automation github-project-automation bot moved this to Triage in Backlog Nov 22, 2024
@m0mus m0mus added the P3 label Nov 25, 2024
@m0mus m0mus moved this from Triage to Normal priority in Backlog Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues for 3.x version branch docs enhancement New feature or request P3 performance server
Projects
Status: Normal priority
Development

No branches or pull requests

2 participants