🪲 Check if classes and levels exist in adv #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasan-sh
suggested changes
Mar 21, 2024
website/for_teachers.py
Outdated
Comment on lines
1078
to
1079
| if body.get("classes") and current_adventure.get('classes'): | ||
| current_classes = current_adventure["classes"] |
There was a problem hiding this comment.
Imagine current_adventure being an existing adventure. It most likely doesn't have classes, therefore the next line should be changed.
Suggested change
| if body.get("classes") and current_adventure.get('classes'): | |
| current_classes = current_adventure["classes"] | |
| if body.get("classes"): | |
| current_classes = current_adventure.get('classes', []) |
Same goes for the levels you made below and all other places you use classes as well!
There was a problem hiding this comment.
These are the only places
hasan-sh
approved these changes
Mar 25, 2024
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5289