💻 For teachers redesign #5265
Merged
💻 For teachers redesign #5265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into for-teachers-redesign
|
Hi @Annelein so instead of solving this problem, which we could, why don't we follow the same style of the other "view ..." buttons? So, just create a table and when you click on view slides, that table appears and the user is navigated to it. |
|
What do you think? |
… into for-teachers-redesign
|
@jpelay added it! So it's ready to be reviewed! |
Awesome! Will review some other PRs and then come back to this one! |
jpelay
reviewed
Mar 21, 2024
| {% if second_teacher and role == 'viewer' %}disabled{% endif %}>{{_('create_class')}}</button> | ||
| {% if teacher_classes %} | ||
| <button class="white-btn inline-flex items-center gap-2" id="view_classes" | ||
| _="on load hedyApp.getForTeacherTable('classes_table') end |
There was a problem hiding this comment.
Great usage of Hyperscript and javascript!
…calstorage for tests
… into for-teachers-redesign
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The design