Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make use of the width/height attributes for images in the models and components #173

Open
reusr1 opened this issue Dec 4, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request Release 1.0.0

Comments

@reusr1
Copy link
Contributor

reusr1 commented Dec 4, 2020

with the introduction of headwirecom/peregrine-cms#671 we support extraction of width and height from assets in the sling models. We should make use of this feature in themecleanflex to render sensible defaults to prevent layout shifts and force the browser to save space for the image that will be loaded

possible approaches:

@Felix-Puetz do you know others?

@reusr1 reusr1 added the enhancement New feature or request label Dec 4, 2020
@flx-sta
Copy link
Collaborator

flx-sta commented Dec 4, 2020

Haven't really worked much with a feature like that in the past. There is a vue-lazyload too but that's it

@reusr1
Copy link
Contributor Author

reusr1 commented Dec 4, 2020

Haven't really worked much with a feature like that in the past. There is a vue-lazyload too but that's it

we are already using vue-lazyload in themecleanflex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Release 1.0.0
Projects
None yet
Development

No branches or pull requests

3 participants