-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum Updates for percli to run peregrine on Sling 12 based instance #18
Comments
@cmrockwell I am wondering if we want to push 2) to github instead - it could make sense to have these files on https://github.com/peregrine-cms with a repo to build and publish the latest version to decouple this headwire dependency |
@reusr1 That sounds like a great idea |
Another thing to think about is how start and stop scripts will work without support for sling.properties and without a Starter jar that takes 'start', 'stop' , 'status', or 'threads' |
we may want to consider the sling kickstarter for peregrine instead of launching a feature model directly. After all that's what it was written for https://sling.apache.org/documentation/feature-model/howtos/kickstart.html |
Kickstart is either not working or I'm doing it wrong. I'm testing it with the script below, and have some issues:
Ideas?
|
In the short run, my project start.sh will probably look more like this one. which is basically the same way as @GastonGonzalez 's DockerFile setup. This avoids certain issues mentioned above, and matches the way I've been running and testing locally. Though I could see switching to Kickstart after the initial merge.
|
I created this issue to add support for the Kickstarter. Once this ticket is resolved, I'll take this ticket. |
Corresponding to a Sling 12 based launcher, percli needs a few changes.
--sling
or-s
is the sling version. There needs to be an option for 12https://github.com/headwirecom/percli/blob/master/bin/percli-server-install#L42
Sling 12 needs a launcher (org.apache.sling.feature.launcher.jar) and feature aggregate (feature-oak_tar.json). I presume those need to be hosted on headwire's vagrant. and referenced in
https://github.com/cmrockwell/peregrine-cms/blob/upgrade/sling12-PM-Java11/docker/scripts/start.sh
Run modes and TCP port previously set in sling/sling.properties need to be set using launcher framework properties -D properties. For example:
java -jar org.apache.sling.feature.launcher.jar -f feature-oak_tar_fds.json -D sling.runmodes=author,notshared,oak_tar,fds -p sling
The text was updated successfully, but these errors were encountered: