-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: HTML rendering of objects with links #1057
Comments
I'm having trouble reproducing the example. When I run |
OK, yes, it looks like you fixed this here 2 weeks ago Thanks for doing that! The message looks great. I guess I did not test with the latest pynwb dev branch. I didn't think to update pynwb to test this because I expected the solution to be in hdmf, where the rest of the plotting code lives. While your solution does indeed handle the TimeSeries problem, this issue could come up with any other type that contains links/references, so I think it is also a good idea to build some sort of general cycle detection in the HDMF base class. |
That makes sense to make a more general solution for links/references in the hdmf class so that the solution is where the rest of the plotting code is. From what I understand, the recursion error was happening in this case specifically because in addition to the link in Maybe also related to #1043? If an object is a link, we can indicate that in the html representation and also stop any circular references. |
OK, since the immediate issue is fixed (thanks again for this btw), let's close this and change the corresponding PR to draft mode. We can reopen if this types of thing comes up again. |
What happened?
When trying to render an HDMF (or PyNWB) object with a reference to another object, it can cause an infinite recursion error.
In the following code:
ts1
renders as expected, butts2._repr_html_()
andts3._repr_html_()
both cause errors:ts2
ts3
Steps to Reproduce
Traceback
No response
Operating System
macOS
Python Executable
Conda
Python Version
3.12
Package Versions
No response
The text was updated successfully, but these errors were encountered: