Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make minimum noise/audio filters depending on radio model #122

Closed
hbeni opened this issue May 29, 2021 · 1 comment · Fixed by #145
Closed

Make minimum noise/audio filters depending on radio model #122

hbeni opened this issue May 29, 2021 · 1 comment · Fixed by #145
Assignees
@hbeni
Labels
Audio effects Affecting audio effects enhancement New feature or request low prio Low priority mumble-plugin Affecting mumble plugin Radio-model Affecting radio wave model
Milestone
1.0

Comments

@hbeni
Copy link
Owner

hbeni commented May 29, 2021 •
edited
Loading

Currently the audio lib adds minimum noise (and other filters) even for pristine radio signal quality.
The values for this should be depending on the actual radio model in use, since the audio quality can differ depending n the model.

related to #58
@hbeni hbeni added enhancement New feature or request mumble-plugin Affecting mumble plugin low prio Low priority Radio-model Affecting radio wave model labels May 29, 2021
@hbeni hbeni modified the milestones: 1.0, Soon™ (=Future) May 29, 2021
@hbeni hbeni changed the title Make minimum noise depending on radio model Make minimum noise/audio filters depending on radio model Jun 3, 2021
@hbeni hbeni added the Audio effects Affecting audio effects label Jun 6, 2021
@hbeni
Copy link
Owner Author

hbeni commented Jun 6, 2021

Probably easiest is:

  • instanciate the radio model as member of the radio data struct, whenever its frq changes
  • Add a entry function to the radio model class to process samples based on a quality result
  • Add a base implementation to the radio model, which uses the helpers of the existing audio module
  • Make the plugin call the respective radio models process function instead of the functions provided from the audio module directly

=> this will make overloading audio processing easy

@hbeni hbeni mentioned this issue Aug 28, 2021
Closed
5 tasks
@hbeni hbeni modified the milestones: Soon™ (=Future), 1.0 Aug 28, 2021
@hbeni hbeni self-assigned this Aug 30, 2021
hbeni added a commit that referenced this issue Aug 30, 2021
@hbeni
Plugin: refactored audio filters to be model specific
952f556 
The previously global audio filters are now part of the radio model.
Now we can define different audio filter characteristics for different radio models.
This also made the mumble_onAudioSourceFetched a little less long and a little more generic.

Fix #122
Helps with #58
@hbeni hbeni linked a pull request Aug 30, 2021 that will close this issue
Restructure audio callback #145
Merged
hbeni added a commit that referenced this issue Aug 30, 2021
@hbeni
Plugin: refactored audio filters to be model specific
3abc7bb 
The previously global audio filters are now part of the radio model.
Now we can define different audio filter characteristics for different radio models.
This also made the mumble_onAudioSourceFetched a little less long and a little more generic.

Fix #122
Helps with #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hbeni hbeni

Labels
Audio effects Affecting audio effects enhancement New feature or request low prio Low priority mumble-plugin Affecting mumble plugin Radio-model Affecting radio wave model
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Restructure audio callback hbeni/fgcom-mumble
1 participant
@hbeni