Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Moves code in useEffect into main body of component #673 #674

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: Moves code in useEffect into main body of component #673 #674

merged 1 commit into from
Nov 21, 2023

Conversation

phantomjinx
Copy link
Member

No description provided.

@phantomjinx phantomjinx force-pushed the remove-useeffect-login branch from 06fb585 to 9e4ad86 Compare November 20, 2023 16:34
@hawtio-ci
Copy link

hawtio-ci bot commented Nov 20, 2023 •
edited
Loading

Test results

Run attempt: 812
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(11)-firefox 59 58 1 0 0 305.695
results-quarkus-node(18)-java(17)-firefox 59 58 1 0 0 304.627
results-quarkus-node(20)-java(11)-firefox 59 58 1 0 0 306.611
results-quarkus-node(20)-java(17)-firefox 59 58 1 0 0 302.962
results-springboot-node(18)-java(11)-firefox 58 57 1 0 0 307.407
results-springboot-node(18)-java(17)-firefox 58 57 1 0 0 295.06
results-springboot-node(20)-java(11)-firefox 58 57 1 0 0 298.56
results-springboot-node(20)-java(17)-firefox 58 57 1 0 0 302.42

@github-actions GitHub Actions
Copy link

Test Results

    8 files  ±0      8 suites  ±0   40m 23s ⏱️ +13s
  59 tests ±0    58 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
468 runs  ±0  460 ✔️ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 9e4ad86. ± Comparison against base commit 3ff43cc.

tadayosi
tadayosi approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tadayosi tadayosi merged commit 1f54014 into hawtio:main Nov 21, 2023
13 checks passed
@tadayosi tadayosi linked an issue Nov 27, 2023 that may be closed by this pull request
Replace the useEffect in HawtioLogin #673
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@tadayosi tadayosi tadayosi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the useEffect in HawtioLogin
3 participants
@phantomjinx @tadayosi @oscerd