Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Springboot-plugin): Init plugin for the spring-boot with Health, Loggers and Info pages #669

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

mmelko
Copy link
Collaborator

@mmelko mmelko commented Nov 15, 2023

This is first part of the spring-boot plugin:

With the health I divided the health components into separate tabs with separate status distinction
image

image

to have all of the health plugins exposed I had to set:
management.endpoints.jmx.exposure.include=* in the spring-boot application.properties

Copy link

github-actions bot commented Nov 15, 2023

Test Results

    8 files  ±0      8 suites  ±0   40m 36s ⏱️ - 6m 4s
  59 tests ±0    58 ✔️ ±0  1 💤 ±0  0 ±0 
468 runs  ±0  460 ✔️ ±0  8 💤 ±0  0 ±0 

Results for commit 64ce333. ± Comparison against base commit 44f4d34.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Nov 15, 2023

Test results

Run attempt: 810
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(11)-firefox 59 58 1 0 0 312.261
results-quarkus-node(18)-java(17)-firefox 59 58 1 0 0 303.549
results-quarkus-node(20)-java(11)-firefox 59 58 1 0 0 300.018
results-quarkus-node(20)-java(17)-firefox 59 58 1 0 0 302.022
results-springboot-node(18)-java(11)-firefox 58 57 1 0 0 310.258
results-springboot-node(18)-java(17)-firefox 58 57 1 0 0 300.41
results-springboot-node(20)-java(11)-firefox 58 57 1 0 0 298.005
results-springboot-node(20)-java(17)-firefox 58 57 1 0 0 309.817

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Some comments are necessary to change.

packages/hawtio/src/plugins/springboot/Springboot.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/springboot/Springboot.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/springboot/Springboot.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/springboot/index.ts Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/springboot/index.ts Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/springboot/index.ts Outdated Show resolved Hide resolved
packages/hawtio/src/plugins/springboot/types.ts Outdated Show resolved Hide resolved
@tadayosi
Copy link
Member

Also please fix lint errors. I recommend you running yarn lint && yarn format:check before submitting a pull req every time.

@tadayosi
Copy link
Member

@mmelko What versions of Spring Boot have you tested it with? We should make sure both v2 & v3 work with the plugin.

@mmelko mmelko force-pushed the springboot-plugin branch 2 times, most recently from 1feb4fe to e019d80 Compare November 16, 2023 10:16
@mmelko mmelko changed the title feat(Springboot-plugin): Init plugin for the spring-boot with Health and Info pages feat(Springboot-plugin): Init plugin for the spring-boot with Health, Loggers and Info pages Nov 16, 2023
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple more comments. Otherwise, it looks good.

packages/hawtio/src/plugins/logs/Logs.tsx Outdated Show resolved Hide resolved
packages/hawtio/src/ui/notification/HawtioNotification.tsx Outdated Show resolved Hide resolved
@tadayosi tadayosi merged commit b8ba2cd into hawtio:main Nov 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants