-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Springboot-plugin): Init plugin for the spring-boot with Health, Loggers and Info pages #669
Conversation
Test resultsRun attempt: 810
|
846e77e
to
e9333f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Some comments are necessary to change.
Also please fix lint errors. I recommend you running |
@mmelko What versions of Spring Boot have you tested it with? We should make sure both v2 & v3 work with the plugin. |
1feb4fe
to
e019d80
Compare
e019d80
to
8dbc221
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple more comments. Otherwise, it looks good.
…r and customize loggers
3d825bf
to
64ce333
Compare
This is first part of the spring-boot plugin:
With the health I divided the health components into separate tabs with separate status distinction
to have all of the health plugins exposed I had to set:
management.endpoints.jmx.exposure.include=*
in the spring-boot application.properties