Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared): upgrade jolokia.js to 2.0.0-dev.9 #569

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

tadayosi
Copy link
Member

The new official jolokia.js should be backward compatible with Jolokia 1.x, so it should be fine to upgrade the js client library in advance for the coming Jolokia 2.0 release.

The new jolokia.js should also support both Jolokia 1.x and 2.x agents with a single distribution.

Based on jolokia/jolokia#574

@tadayosi
Copy link
Member Author

@phantomjinx @mmelko I asked your reviews just because it's an important change to know for the Hawtio developers.

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Test Results

    7 files   -   1      7 suites   - 1   52m 19s ⏱️ +4s
  59 tests ±  0    58 ✔️ ±  0  1 💤 ±0  0 ±0 
410 runs   - 58  403 ✔️  - 57  7 💤  - 1  0 ±0 

Results for commit c2c8679. ± Comparison against base commit 4031957.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Sep 25, 2023

Test results

Run attempt: 470
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(16)-java(11)-firefox 59 58 1 0 0 465.784
results-quarkus-node(16)-java(17)-firefox 59 58 1 0 0 431.647
results-quarkus-node(18)-java(11)-firefox 59 58 1 0 0 365.811
results-quarkus-node(18)-java(17)-firefox 59 58 1 0 0 413.897
results-springboot-node(16)-java(11)-firefox 58 57 1 0 0 484.526
results-springboot-node(16)-java(17)-firefox 58 57 1 0 0 514.457
results-springboot-node(18)-java(11)-firefox 58 57 1 0 0 462.994

Copy link
Member

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/hawtio/package.json Show resolved Hide resolved
The new official jolokia.js should be backward compatible with Jolokia
1.x, so it should be fine to upgrade the js client library in advance
for the coming Jolokia 2.0 release.

The new jolokia.js should also support both Jolokia 1.x and 2.x agents
with a single distribution.
@tadayosi tadayosi merged commit 08ae86c into hawtio:main Sep 26, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants