Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Assistant Data Science no longer works via this add-on #634

Closed
rct opened this issue Oct 13, 2024 · 4 comments
Closed

Home Assistant Data Science no longer works via this add-on #634

rct opened this issue Oct 13, 2024 · 4 comments

Comments

@rct
Copy link

rct commented Oct 13, 2024

Problem/Motivation

Home Assistant Data Science which is linked from home-assistant.io page footers, it no longer works and appears to have not worked since spring of 2023. The instructions (Quick Start Guide) say to use this add-on to run https://github.com/robmarkcole/HASS-data-detective/. The example notebook, GETTING_STARTED.ipynb fails at the first DB query under "Popular entries"

See robmarkcole/HASS-data-detective#157 and home-assistant/data.home-assistant#292 for bug reports others have opened.

Expected behavior

(What you expected to happen)

I would expect an example linked from the main home-assistant.io pages to work.

Actual behavior

(What actually happened)

Database query fails -- See robmarkcole/HASS-data-detective#157 and home-assistant/data.home-assistant#292 for bug reports others have opened.

Steps to reproduce

(How can someone else make/see it happen)

Follow Home Assistant Data Science Quick Start Guide say to use this add-on to run https://github.com/robmarkcole/HASS-data-detective/

Proposed changes

(If you have a proposed change, workaround or fix,
describe the rationale behind it)

If Home Assistant Data Science via @robmarkcole's HASS-data-detective can still work with current versions of Home Assistant, please update this add-on to include current working modules.

If not consider:

  • Removing the home assistant data science links from home-assistant.io
  • Adding a note to this add-on's readme that Home Assistant Data Science no longer works.
  • Remove HASS-data-detective from this add-on to prevent people from spinning their wheels.

Thank you.

@rct
Copy link
Author

rct commented Oct 13, 2024

See this issue for more details on what's broken: robmarkcole/HASS-data-detective#157 (comment)

  1. HASS-Data-Detective has a newer/renamed example notebook which seems to work (though with a few warnings) with the add-on as currently released.
  2. 3.1 is the current release of HASS-Data-Detective, though it still has a requirement of sqlalchemy==2.0.7. The add-on is currently pulling in 2.0.35 which does not work with the notebook in the current build of the add-on.

**EDIT?UPDATE: ** Where does the example GETTING_STARTED notebook that winds up in ./config/notebooks/home-assistant/GETTING_STARTED.ipynb come from? That notebook no longer works. It also isn't the notebook that comes with HASS-Data-Detective 3.0.

@rct
Copy link
Author

rct commented Oct 14, 2024

Note: this was previously reported back in August 2023, #491 - Example "GETTING STARTED.ipynb" is broken but closed by Frenck who mentioned:

The example provided is not maintained by the add-on, but provided by the Home Assistant project. Please report the issue upstream. Once their case is fixed, the add-on will pick it up automatically.

"provided by the Home Assistant project" is a little ambiguous. It is clear the example isn't coming fro the Hass Data Detective repo. Nor does it come from https://github.com/home-assistant/data.home-assistant.

After a bit of searching I finally found the home-assistant-notebooks repo under the home-assistant organization: https://github.com/home-assistant/home-assistant-notebooks

The add-on does have the version of GETTING_STARTED.ipynb that was last updated by @duncandoo on June 9th 2024.

While that notebook was updated, I'm not sure it worked/was tested since it appears that HASS-Data-Detective and therefore the use of it in this add-on has been broken for at least 18 months and is probably due to a chance in SQLAlchemy starting early in 2.x. As discovered by others: db.perform_query() fails if you give it a string.

See robmarkcole/HASS-data-detective#159

@robmarkcole
Copy link

I appreciate the detective work - sounds like a couple of PR are in order

@frenck
Copy link
Member

frenck commented Oct 15, 2024

I'm not sure what you want me to do with this?

I would expect an example linked from the main home-assistant.io pages to work.

Cool, but you are in the wrong project for a comment on that expectation.

If not consider:

🤷 Feel free to provide an upstream fix for issues.

"provided by the Home Assistant project" is a little ambiguous.

Agree. Let me put it this way: Not here :)

I'm closing it on this end, as there is nothing I can do from this end to solve this issue. If upstream fixes are applied, I'm happy to ship/tag an updated release of this add-on.

../Frenck

@frenck frenck closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants