Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow validation of json against a json schema file #95

Open
susannemoog opened this issue Nov 17, 2017 · 2 comments
Open

Allow validation of json against a json schema file #95

susannemoog opened this issue Nov 17, 2017 · 2 comments
Labels
enhancement

Comments

@susannemoog
Copy link

Hey and thanks for the library,

a nice addition could be to allow validation of the config against a defined schema file (for example via https://github.com/justinrainbow/json-schema).

Would you be interested in a pull request in that area?

Susi
@DavidePastore
Copy link
Collaborator

Hi @psychomieze! Sorry for the late reply. Yes, a PR in this sense would be cool! 😄 But be sure to do it for the develop branch.

@hassankhan
Copy link
Owner

My only worry with this is that it would require another dependency, and I'm not sure if it's something most users want (I could be completely wrong though).

Could we do it in such a way that it's an optional dependency for those who need it?

peter279k pushed a commit to open-source-contributions/config that referenced this issue May 8, 2021
@dependabot-preview
Bump phpstan/phpstan from 0.12.81 to 0.12.82 (hassankhan#95)
820256c 
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 0.12.81 to 0.12.82.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Commits](phpstan/phpstan@0.12.81...0.12.82)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@susannemoog @hassankhan @DavidePastore