-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the namespace? #20
Comments
Do you really think so? I quite liked it 😁 Ideas/suggestions? |
I also like it. I think that it is ok. ✌️ |
i see, ok :D no issue then hehe. |
I have a suggestion ... maybe we could move the package to The PHP League, I'm sure we check all the boxes. |
For me it is indifferent, but we have to create an auto redirect from this repo. Anyway I think that this could remain here. |
Pros:
Cons:
|
That's a great idea! With regards to the redirect, once we transfer the source tree under the league, the redirect will automatically happen (covered by github). As for the check list, wrt the Can I just create a branch called |
I've already done the necessary work, I think, just a case of applying to the League. Would you like to send the email to their mailing list or should I? With respect to the changelog, I think we don't need to have one ready right now (though we could). I think the commit history isn't quite specific enough, all we really need to do is pull significant commit messages really. Instead of maintaining a separate branch, I was thinking we could bump to version 1.0, if anyone wants to use the pre-League version they could point to an older tag. |
Draft email: Hi all, We're collaborators on a simple Config package, and we think our package would fit in quite well with The League. https://github.com/noodlehaus/config/ What It Does Config is a file configuration loader that supports PHP, INI, XML, JSON, and YAML files. Files are parsed and loaded depending on the file extension. What Makes It Different Where It's At The Future Thanks for your time, and we hope you'll like our package! Davide Pastore |
Awesome, great. you can go ahead and apply for the package, Hassan. Then if anything needs to be done, let's file the tasks as tickets so we can pick and clear them one by one. Added collaborator status to @DavidePastore. |
Done. Let's see what they say 😨 |
I'm pretty sure thephpleague will ask to drop PHP 5.3 support. Are you ready to do that? |
should be no issue dropping 5.3. we could either drop 5.3 entirely, or supportit unofficially. |
Yeah we can just tag a release as the last supported version for PHP 5.3, no probs. |
Really excited to see if this makes it into the PHPLeague - its a package that is so useful and essential in any app I feel. |
Thanks for the kind words! Just wanted to post this here: https://github.com/thephpleague/thephpleague.github.io/wiki/Package-Submission |
@hassankhan Good job! 💃 |
Thanks @DavidePastore! |
Pinging everyone: been a few replies to the email thread, not thought of a response yet but input is very welcome. Thanks! |
Also created a post on Reddit, feel free to weigh in! |
Got something ready, shall I post it here or somewhere in private? |
What ready? In here is fine I guess. Keep communication open ;-)
|
Okay, here it is: Hi all, First of all, thank you all for replying! Honestly speaking, I hadn't seen Zend's package before (or heard of phpdotenv, cheers Jonathan). The only reason I stumbled into this package is because it showed up before zend/config on Packagist, and was exactly what I needed at the time (and the rest is history). I had seen the Symfony one though, and I've gone back and looked at both more thoroughly to prepare a better argument. Config's own meritsConfig aims to be as simplistic as possible, we don't think it's ideal creating a few objects just to get going. You can load in any file of any format without needing to worry about setting up a thing. Also, another use case that I haven't seen (yet) in other packages is being able to easily create a config object with preset values. This can be useful in any implementing library/project, rather than passing around an options array it can be encapsulated and saved (IoC or however). symfony/config vs ConfigI personally think it's a tiny weeny bit over-engineered. It seems I have to instantiate a fair few classes before I can even use it properly. It does let you validate the settings, which Config doesn't, but it could easily be achieved by using a simple validation library (valitron, anyone) in a subclass. zend/config vs Configzend/config requires a separate class instantiation for each filetype, or another class which can only read PHP arrays. Otherwise it's pretty much the same - had I known about it earlier I probably would've used it. phpdotenv vs ConfigI think that they solve different use-cases, I would use phpdotenv for things like API keys, etc. (sensitive credentials), and I'd use Config for managing my application's runtime settings (Unless I'm mistaken?). That said, I think they would both work nicely along each other, and possibly even complement one another (I've gotten another idea). I guess my closing argument on this topic is that while the above packages do solve "the problem", I don't think they solve them particularly well from a user's perspective. I'm a big fan of how League packages tend to be simplistic and integrate awesomely well with pretty much any application I've used them on so far. About using all available loaders, we're currently thinking about changing this to allow users to specify which loaders they require, so there's that. I hope that answered your questions and hopefully sold it to you :) |
If no-one else has anything to add, I'm going to post the reply above to the mailing list when I get home tonight. Thanks! |
Considering there's been no activity in this issue nor on the thread in the php league mailing list, should we assume |
Yeah they didn't seem too keen on it, but I don't think anyone is averse to changing the namespace if there's any better suggestions? |
Sooooo ... I've set up a new GitHub org and I'm planning on moving it there, unless anyone has any objections? |
It's ok for me. What are the advantages? 😸 |
Not really any advantages, per se, just been waiting to do this a long time but didn't have a decent vendor namespace. |
I guess one advantage would be everyone in the org is an allowed contributor, so lessens the burden overall maybe? |
I agree! 👍 Be free to do it when you want 💃 |
I don't know, Noodlehaus seems to be a really lousy namespace for this, and makes it a bit hard to take the package seriously.
The text was updated successfully, but these errors were encountered: