Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite shuffleListM using array #158

Open
lehins opened this issue Jan 27, 2024 · 0 comments
Open

Rewrite shuffleListM using array #158

lehins opened this issue Jan 27, 2024 · 0 comments

Comments

@lehins
Copy link
Contributor

lehins commented Jan 27, 2024

Initial version of shuffleListM was introduced in #140

Current implementation is very simple and suboptimal, as pointed out in this comment

We need some basic array support with mutation in order to implement Fisher-Yates shuffle. Here is an example of such implementation

I suggest we postpone this implementation until we get #157 taken care of. Which would allow us to depend on primitive, thus making efficient and bias free implementation of shuffleList trivial.

@lehins lehins changed the title Rewrite shiffleListM using array Rewrite shuffleListM using array Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant